Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upload.intended_dataset_type and Upload.intended_organ fields #765

Open
shirey opened this issue Nov 25, 2024 · 1 comment
Open

Add Upload.intended_dataset_type and Upload.intended_organ fields #765

shirey opened this issue Nov 25, 2024 · 1 comment
Assignees

Comments

@shirey
Copy link
Member

shirey commented Nov 25, 2024

Please add two new fields to the Upload entity:

  • intended_dataset_type, holds the intended dataset_type for the datasets included in the upload. It should hold the same code set/value set that is held in Dataset.dataset_type
    • type: string
    • indexed: true
    • description: The dataset type of the intended datasets that will be uploaded as part of the Upload.
    • validation: use the same, incomplete, create/update validation scheme (doesn't need to be the same exact shared implementation, if that is hard) that is used for Dataset.dataset_type. We will handle the full, better validation for both this attribute and Dataset.dataset_type in a separate card/issue.
  • intended_organ, holds the intended organ type that the data in the Upload will be registered against. It should hold the same code set/value set that is held in Sample.organ
    • type: string
    • indexed: true
    • description: The organ code representing the organ type that the data contained in the upload will be registered/associated with.
    • validation: No validation needed. We will handle proper validation for both this attribute and Sample.organ in a separate card/issue.
@yuanzhou
Copy link
Member

Note, these two fields will be required during creation time. They are also required on the UI side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

No branches or pull requests

3 participants