Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Semantic Versioning releases #1925

Open
TheTrueWhiteOwl opened this issue May 14, 2024 · 2 comments
Open

Using Semantic Versioning releases #1925

TheTrueWhiteOwl opened this issue May 14, 2024 · 2 comments

Comments

@TheTrueWhiteOwl
Copy link

TheTrueWhiteOwl commented May 14, 2024

When will nvim-cmp get its next release?

The last and only one (v.0.1.0) was in August 2022, almost two yeas ago...

Hasn't the functionality and the public API of this plugin mostly been defined by now, and hence this plugin should probably already be at major version: 1 (i.e. v1.0.0)?

I believe it would be beneficial if nvim-cmp would start including releases, following (semver)[https://semver.org/] such that users can guarantee that their nvim config does not break when backwards incompatible API changes are made. As an example take a lazy.nvim user:

{
   "hrsh7th/nvim-cmp",
    version = "^1.0.0", -- Would guarantee that lazy would only install versions compatible with version1.0.0 (i.e. 1.0.0<=version<2.0.0)
    dependencies = {
      "L3MON4D3/LuaSnip",
   },
   lazy = true,
   event = "LspAttach",

   opts = {
      sources = {
         {
            name = "nvim_lsp"
         },
      },
      snippet = {
         expand = function(args)
            require("luasnip").lsp_expand(args.body)
         end,
      },
   },
},
@TheTrueWhiteOwl
Copy link
Author

This would also reduce the impacts and the necessity of having this issue (#231) for documenting the breaking changes. These would already be clearly indicated by a change in the major version. (e.g. going from v1.x.x to v2.0.0).

@itaranto
Copy link

Duplicate of #1719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants