Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Input Handling #229

Draft
wants to merge 3 commits into
base: spatter-devel
Choose a base branch
from

Conversation

radelja
Copy link
Contributor

@radelja radelja commented Nov 28, 2024

Overview

This PR updates the handling of invalid input parsed from the command-line and from JSON input files.

✨ Change Description/Rationale

  • --atomic-writes now takes no arguments and is off by default
    • Aligns the behavior of this flag with others, namely --dense-buffers, --compress, and --aggregate
  • Updated read_ul_args() and read_int_args() to use new min_value parameter
  • Now 0 is an invalid value for --pattern-size, --count, --nruns, --nthreads, and --wrap
  • Updated parse_omp_threads_suite_test to reflect 0 as an invalid value for --nthreads
  • Updated LULESH and Nekbone traces, replacing negative deltas with 8 (the default value)
    • Previous Spatter behavior used default delta value when running these app traces
  • Aligned the behavior of JSON parsing with command-line parsing for invalid values
    • JSON parsing no longer uses default values when encountering invalid values
  • Closes Negative Delta Handling #183

👀 Reviewer Checklist

  • All GitHub actions and runners have passed if applicable
  • Commits are clean and relevant

✅ PR Checklist

  • Remove or update the template boilerplate text
  • Commits are relevant and combined where appropriate
  • Rebase off spatter-devel
  • Reviewers Requested
  • Projects associated
  • Commits mention issue and/or PR numbers at the bottom of the message
  • Relevant issues are linked into the PR
  • TODOs are completed
  • Reviewer checklist is updated

🚀 TODOs

  • No additional TODOs for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant