Behavior change in 0.41 breaks functionality of Fey::Object::Iterator::FromSelect

[kgcgs]

Looks like d8efe64 broke Fey::Object::Iterator::FromSelect. The attached patch restores expected behavior in our use case.

fey-sql-select.patch

[ap]

Fey still has users? If I was still one of them I might undertake fixing Fey::Object::Iterator::FromSelect, but as it is, reverting the patch entirely is probably a good idea. Unfortunately due to 4b07297 it can’t be done automatically, but the merge conflicts are trivial. I’ve done that and left a patch in #4 so anyone who needs it doesn’t have to do it themselves.

[kgcgs]

Well, there's at least two enterprise applications built on it that we still have running. I'm just making an effort at being a good open source user and contributing fixes and bug reports. ;)

[autarch]

Thanks for the bug report. I'm not using this myself either and haven't done so for ages. I'd guess that simply applying that patch would break some tests, so I'd be a little wary of applying it as-is. And of course since this code is so ancient I haven't updated it to run on a modern CI system, so even if you submitted a PR it wouldn't run any tests.

That said, maybe you could try this locally?

[ap]

You marked it HANDOFF anyway. Maybe @kgcgs would be up for taking it over, as an active user, rather than having to go through I-don’t-really-care-anymore ex-maintainers/contributors?

[autarch]

You marked it HANDOFF anyway. Maybe @kgcgs would be up for taking it over, as an active user, rather than having to go through I-don’t-really-care-anymore ex-maintainers/contributors?

Yes, that would be great!

[kgcgs]

The patch definitely breaks the tests, if I can convince the dev that brought Fey in to spend the time to figure that out we'd be happy to take ownership of the modules.