Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middleware [logger] & [requestId] logger does not include requestId #3744

Open
valerii15298 opened this issue Dec 12, 2024 · 0 comments
Open
Labels
enhancement New feature or request.

Comments

@valerii15298
Copy link

What is the feature you are proposing?

There is logger and requestId middleware inside hono. But logger middleware does not include requestId into logs. And it(logger middleware) is pretty much useless in any app where monitoring by requests is needed.
When you log request elapsed time you wanna know for which request is it. I do not see any reason to have it separate. Logging requestId is essential key part for tracing and monitoring an app.

I would suggest to combine these to things or make it possible to include requestId into logs.

@valerii15298 valerii15298 added the enhancement New feature or request. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant