Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dyff-1.8.0 fails to work with kustomize build and kubectl diff #377

Open
phlo46 opened this issue Jul 23, 2024 · 0 comments
Open

dyff-1.8.0 fails to work with kustomize build and kubectl diff #377

phlo46 opened this issue Jul 23, 2024 · 0 comments

Comments

@phlo46
Copy link

phlo46 commented Jul 23, 2024

dyff 1.8.0, installed with a prebuilt linux_amd64 binary, does not work well with kustomize, kubectl.

export KUBECTL_EXTERNAL_DIFF="dyff-1.8.0 between --omit-header --set-exit-code"

kustomize-5.2.1 build overlays/dev | kubectl-1.30.2 diff -f -

Returns error:

╭ Error occurred
│ unknown command "/tmp/LIVE-3181116135" for "dyff-1.8.0"
╵
error: failed to run "dyff": exit status 255

My default kubectl diff output looks like this:

diff -u -N /tmp/LIVE-2884575271/admissionregistration.k8s.io.v1.MutatingWebhookConfiguration..admission-webhook-mutating-webhook-configuration /tmp/MERGED-4097369848/admissionregistration.k8s.io.v1.MutatingWebhookConfiguration..admission-webhook-mutating-webhook-configuration

--- /tmp/LIVE-2884575271/admissionregistration.k8s.io.v1.MutatingWebhookConfiguration..admission-webhook-mutating-webhook-configuration	2024-07-23 14:59:27.954053635 +0700
+++ /tmp/MERGED-4097369848/admissionregistration.k8s.io.v1.MutatingWebhookConfiguration..admission-webhook-mutating-webhook-configuration	2024-07-23 14:59:27.954053635 +0700

So I think this issue is very similar to #235 but I install dyff with prebuilt binaries, not via snap.

But if I use dyff-1.7.1, it works as expected:

export KUBECTL_EXTERNAL_DIFF="dyff-1.7.1 between --omit-header --set-exit-code"

I guess that the new 1.8.0 version may have a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant