From d74782cddc92ab891a1edeedb286241c713f65df Mon Sep 17 00:00:00 2001 From: Stefan Agner Date: Thu, 12 Sep 2024 11:48:50 +0200 Subject: [PATCH 1/2] Lower "Activity on mDNS" message Users seem to get added mDNS events fairly regularly, and with that the log message. However, the trigger_resubscribe_if_scheduled does not do anything typically, so let's lower the log level here to avoid polluting the log unnecessarily. --- matter_server/server/device_controller.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/matter_server/server/device_controller.py b/matter_server/server/device_controller.py index dc3e0e5a..a37b9954 100644 --- a/matter_server/server/device_controller.py +++ b/matter_server/server/device_controller.py @@ -1481,7 +1481,13 @@ def _on_mdns_operational_node_state( self._setup_node_create_task(node_id) elif state_change == ServiceStateChange.Added: # Trigger node re-subscriptions when mDNS entry got added - node_logger.info("Activity on mDNS, trigger resubscribe") + # Note: Users seem to get such mDNS messages fairly regularly, and often + # the subscription to the device is healthy nad fine. This is not a problem + # since trigger_resubscribe_if_scheduled won't do anything in that case + # (no resubscribe is scheduled). + # But this does speedup the resubscription process in case the subscription + # is already in resubscribe mode. + node_logger.debug("Activity on mDNS, trigger resubscribe if scheduled") asyncio.create_task( self._chip_device_controller.trigger_resubscribe_if_scheduled( node_id, "mDNS state change detected" From 9c7c9839cf24eb2f537dae438b67fb9d7ad2d26c Mon Sep 17 00:00:00 2001 From: Stefan Agner Date: Thu, 12 Sep 2024 13:21:43 +0200 Subject: [PATCH 2/2] Update matter_server/server/device_controller.py Co-authored-by: Marcel van der Veldt --- matter_server/server/device_controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/matter_server/server/device_controller.py b/matter_server/server/device_controller.py index a37b9954..5f730ff5 100644 --- a/matter_server/server/device_controller.py +++ b/matter_server/server/device_controller.py @@ -1482,7 +1482,7 @@ def _on_mdns_operational_node_state( elif state_change == ServiceStateChange.Added: # Trigger node re-subscriptions when mDNS entry got added # Note: Users seem to get such mDNS messages fairly regularly, and often - # the subscription to the device is healthy nad fine. This is not a problem + # the subscription to the device is healthy and fine. This is not a problem # since trigger_resubscribe_if_scheduled won't do anything in that case # (no resubscribe is scheduled). # But this does speedup the resubscription process in case the subscription