Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: spacing inconsistencies in main page #651

Open
matthewvogas opened this issue Dec 20, 2024 · 12 comments · Fixed by #652 or #654
Open

bug: spacing inconsistencies in main page #651

matthewvogas opened this issue Dec 20, 2024 · 12 comments · Fixed by #652 or #654
Assignees
Labels
type: bug Something isn't working

Comments

@matthewvogas
Copy link
Contributor

AtHoldex should be "At holdex" too, and the space

Screenshot 2024-12-20 at 1 51 42 PM
@matthewvogas
Copy link
Contributor Author

@lmontero18 pls check for more bugs into the head section and resolve them in a single PR

@lmontero18
Copy link
Contributor

lmontero18 commented Dec 20, 2024

@matthewvogas One question, the pr title needs to be with the "bug: title of the pr"?

@matthewvogas
Copy link
Contributor Author

@matthewvogas One question, the pr title needs to be with the "bug: title of the pr"?

pls read the guidelines. In this case is fix(ui): ...
image

@zolotokrylin
Copy link
Member

zolotokrylin commented Dec 21, 2024

Guys, we still have a spacing issue on mobile (please check it everywhere):

image

@zolotokrylin zolotokrylin reopened this Dec 21, 2024
@zolotokrylin zolotokrylin added the type: bug Something isn't working label Dec 21, 2024
@matthewvogas
Copy link
Contributor Author

Guys, we still have a spacing issue on mobile (please check it everywhere):

image

@lmontero18 follow up, pls take care of it in other PR.

And pls In the last PR mark in to #652 the PR that introduced the bug:

Screenshot 2024-12-22 at 10 44 54 AM

@lmontero18 lmontero18 changed the title bug: the space between the head title and the stats is incorrect bug: spacing inconsistencies in mobile layout Dec 22, 2024
@lmontero18 lmontero18 changed the title bug: spacing inconsistencies in mobile layout bug: spacing inconsistencies in the Learn section on mobile Dec 22, 2024
@matthewvogas
Copy link
Contributor Author

@lmontero18 pls take care of responsive always, have in mind 'mobile first' metodology. Do it pixel perfect following figma designs or in this case, other sections. Thanks!

@lmontero18
Copy link
Contributor

Thanks for the feedback, I'll apply the mobile first methodology!

@zolotokrylin
Copy link
Member

  1. Do you mind fixing the same issue with the Hero?

image

  1. Something is wrong with "Looking for Learn more" vertical spacing.

image

image

@zolotokrylin
Copy link
Member

@matthewvogas @lmontero18, please check how did this happen
image

@zolotokrylin zolotokrylin reopened this Jan 1, 2025
@matthewvogas matthewvogas changed the title bug: spacing inconsistencies in the Learn section on mobile bug: spacing inconsistencies in main page Jan 1, 2025
@lmontero18
Copy link
Contributor

lmontero18 commented Jan 2, 2025

@zolotokrylin hi, where is that?

@zolotokrylin
Copy link
Member

1 similar comment
@zolotokrylin
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
3 participants