Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: color scheme script is lagging #399

Open
zolotokrylin opened this issue Jun 16, 2023 · 12 comments
Open

Problem: color scheme script is lagging #399

zolotokrylin opened this issue Jun 16, 2023 · 12 comments
Labels
type: bug Something isn't working value: low this brings very little value, if any at all

Comments

@zolotokrylin
Copy link
Member

          can you pls visit https://29f1-117-242-110-84.ngrok-free.app/ and see if this works for you? works locally for me but not on this, button is unreponsive

Originally posted by @surajsharma in #397 (comment)

@zolotokrylin zolotokrylin added the type: bug Something isn't working label Jun 16, 2023
@zolotokrylin zolotokrylin added this to the Reader experience milestone Jun 16, 2023
@zolotokrylin
Copy link
Member Author

@power-f-GOD you can claim it

@surajsharma
Copy link
Contributor

@power-f-GOD i believe you can do it canonically, take a look https://www.youtube.com/watch?v=3GpZkVBjXfE

@power-f-GOD
Copy link
Contributor

power-f-GOD commented Jun 16, 2023

Ok, @zolotokrylin . My experience with ngrok is that, sometimes, it can be slow in loading assets. But can we confirm that this problem occurs in the preview on Vercel?

@surajsharma
Copy link
Contributor

@power-f-GOD there's lag on localhost for me, not on ngrok. on ngrok it doesn't work at all, this increases the chances it will not on vercel, i could be wrong

@power-f-GOD
Copy link
Contributor

It's not the same for me, @surajsharma .

See this screen record.

Is it the same for you @zolotokrylin ?

@zolotokrylin
Copy link
Member Author

checking

@zolotokrylin
Copy link
Member Author

while I am building locally, I have an assumption that it relates to hydration

@zolotokrylin
Copy link
Member Author

zolotokrylin commented Jun 16, 2023

Locally the glitch is there, but it just loads faster.
My assumption: what happens is that you are:

  1. receiving backend rendered (SSR) UI, then
  2. hydration happens and your onMount script fires and does the job

But, it should be done not in step 2, but in step 1. So you need to capture the cookie with the server-side request handler and process it based on the cookie value.

This is my quick guess @power-f-GOD

@zolotokrylin
Copy link
Member Author

I guess that's why George mentioned, that it should be in the cookie, and not in the localStorage... just another guess

@power-f-GOD
Copy link
Contributor

Ok. Can we have a quick Meets call, let me see what it is like on your end, and you'll see mine also?

https://meet.google.com/hev-ywgq-dhg

@zolotokrylin
Copy link
Member Author

zolotokrylin commented Jun 16, 2023

Log:

  • we had a quick call and we have assigned the priority as VERY LOW to this issue.
  • meanwhile, @surajsharma could you please share with us your screen recording so we can check how it functions on your side? Thanks!

@surajsharma
Copy link
Contributor

@markholdex markholdex added the value: low this brings very little value, if any at all label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working value: low this brings very little value, if any at all
Projects
None yet
Development

No branches or pull requests

4 participants