Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: can't see the amout of views an article has #373

Open
1 task
markholdex opened this issue Jun 12, 2023 · 15 comments · May be fixed by #569
Open
1 task

Problem: can't see the amout of views an article has #373

markholdex opened this issue Jun 12, 2023 · 15 comments · May be fixed by #569
Assignees
Labels
dep: blocked Issue or PR creates is blocked by another task

Comments

@markholdex
Copy link
Contributor

markholdex commented Jun 12, 2023

Figma design

Blocked by

Preview Give feedback
  1. type: bug
@winter-sols
Copy link
Contributor

@markholdex @georgeciubotaru
Please share the backend url to request.

@georgeciubotaru
Copy link
Contributor

@winter-sols I think you should first check the application and the codebase.

@winter-sols
Copy link
Contributor

@georgeciubotaru
I just checked it again.
I am still not sure how backend calculates the number of visit.

Could you help me?

@georgeciubotaru
Copy link
Contributor

@winter-sols Have you found in the code the place where you need to add the views block?

@markholdex
Copy link
Contributor Author

@winter-sols have you completed the front-end part already?

@markholdex @georgeciubotaru Please share the backend url to request.

@winter-sols
Copy link
Contributor

winter-sols commented Jul 21, 2023

@winter-sols Have you found in the code the place where you need to add the views block?
@markholdex @georgeciubotaru
Of course I found.
image

But I am not sure what api to call?

@georgeciubotaru
Copy link
Contributor

Problem: Frontend app doesn't send ThreadViewed events to the posthog.

@markholdex
Copy link
Contributor Author

@winter-sols Have you found in the code the place where you need to add the views block?
@markholdex @georgeciubotaru
Of course I found.
image

But I am not sure what api to call?

The API call should also be there in place. But right now we are blocked by the new reported issue. You can move to a different one for now.

@winter-sols
Copy link
Contributor

Okay

@call3hudson
Copy link

@markholdex
I'm working on this issue now, the problem is I can't find any sign of posthog?

@markholdex
Copy link
Contributor Author

Hey @call3hudson you're right. I didn't check on my side that PostHog requests are still being sent from the backend. Then leave it as is for now.

@call3hudson
Copy link

Hey @call3hudson you're right. I didn't check on my side that PostHog requests are still being sent from the backend. Then leave it as is for now.

Ok, then I will push ui fix as an independent PR

@zolotokrylin
Copy link
Member

zolotokrylin commented Jan 6, 2024

@markholdex @georgeciubotaru
Does it mean the following?

  1. Backend already registers views when "get article" request is executed?
  2. because we have caching layer, we don't register views that hit the cache

@georgeciubotaru
Copy link
Contributor

@zolotokrylin

  1. Backend shouldn't count the request, but the frontend should do it
  2. No issues with caching

@zolotokrylin
Copy link
Member

@georgeciubotaru please provide technical requirement for developers here. Let's resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dep: blocked Issue or PR creates is blocked by another task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants