Error message for wrong file type refactored. #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts
Outdated
Show resolved
Hide resolved
...case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts
Outdated
Show resolved
Hide resolved
andywilkinshmcts
requested changes
Nov 21, 2023
...case-ui-toolkit/src/lib/shared/components/palette/document/write-document-field.component.ts
Show resolved
Hide resolved
@andywilkinshmcts Done! |
olusegz07
previously approved these changes
Nov 24, 2023
andywilkinshmcts
previously approved these changes
Nov 27, 2023
OgunyemiO
dismissed stale reviews from andywilkinshmcts and olusegz07
via
0933425
|
Kudos, SonarCloud Quality Gate passed! |
…ted-file-type-error
RiteshHMCTS
added a commit
that referenced
this pull request
Jan 25, 2024
* Error message for wrong file type refactored. (#1619) * Error message for wrong file type refactored. * check statement added * initialise errorMsg * PR review comments fix * version number change --------- Co-authored-by: RiteshHMCTS <[email protected]> * datetime format error fix and unit test (#1615) * datetime format error fix and unit test * Date format changed to correct incorrect display * version number changed --------- Co-authored-by: RiteshHMCTS <[email protected]> * Ex UI 1112 new branch update hearing requirements event is stuck (#1630) * objects validation to prevent runtime errors * unit test * version change and code fix * added else clause --------- Co-authored-by: RiteshHMCTS <[email protected]> * remove dynamic list field if value is null frm CYA (#1648) * remove dynamic list field if value is null frm CYA * simplified the code * Added serviceId params to request (#1557) * Added serviceId params to request * added a new model file. Unsubscribe subjects * getOrgService func modified * duplicate logic removed * console log msg removed * Unit tests * version changed * Linting issue fixed * version no change * version no changed to a newer version * yarn audit * version number changed * package json file --------- Co-authored-by: RiteshHMCTS <[email protected]> * exui-1152 (#1646) * exui-1152 * version updated along with sonar failure issue * sonar issue * EXUI-830 screen fixes when event raised (#1631) * Error log added to handleError function * code comment modified --------- Co-authored-by: RiteshHMCTS <[email protected]> * unit test fix * sonar failure * unit test added * Bug/e UI 1229 event complete before task (#1656) * Rearranging event and task completion Event completion now set to occur before task completion * linting and testing * Additional code changes Edit for more appropriate code * Change version for tag * Add new tests for sonar issues Also clean code slightly * Slight technical improvement * Revert "Slight technical improvement" This reverts commit 55c40f3. * Add event completion logic in case of task completion error --------- Co-authored-by: RiteshHMCTS <[email protected]> * release notes updated * version updated * version updated * release notes updated with version number --------- Co-authored-by: OgunyemiO <[email protected]> Co-authored-by: connorpgpmcelroy <[email protected]>
connorpgpmcelroy
added a commit
that referenced
this pull request
Feb 8, 2024
* Error message for wrong file type refactored. (#1619) * Error message for wrong file type refactored. * check statement added * initialise errorMsg * PR review comments fix * version number change --------- Co-authored-by: RiteshHMCTS <[email protected]> * datetime format error fix and unit test (#1615) * datetime format error fix and unit test * Date format changed to correct incorrect display * version number changed --------- Co-authored-by: RiteshHMCTS <[email protected]> * Ex UI 1112 new branch update hearing requirements event is stuck (#1630) * objects validation to prevent runtime errors * unit test * version change and code fix * added else clause --------- Co-authored-by: RiteshHMCTS <[email protected]> * remove dynamic list field if value is null frm CYA (#1648) * remove dynamic list field if value is null frm CYA * simplified the code * Added serviceId params to request (#1557) * Added serviceId params to request * added a new model file. Unsubscribe subjects * getOrgService func modified * duplicate logic removed * console log msg removed * Unit tests * version changed * Linting issue fixed * version no change * version no changed to a newer version * yarn audit * version number changed * package json file --------- Co-authored-by: RiteshHMCTS <[email protected]> * exui-1152 (#1646) * exui-1152 * version updated along with sonar failure issue * sonar issue * EXUI-830 screen fixes when event raised (#1631) * Error log added to handleError function * code comment modified --------- Co-authored-by: RiteshHMCTS <[email protected]> * unit test fix * sonar failure * unit test added * Bug/e UI 1229 event complete before task (#1656) * Rearranging event and task completion Event completion now set to occur before task completion * linting and testing * Additional code changes Edit for more appropriate code * Change version for tag * Add new tests for sonar issues Also clean code slightly * Slight technical improvement * Revert "Slight technical improvement" This reverts commit 55c40f3. * Add event completion logic in case of task completion error --------- Co-authored-by: RiteshHMCTS <[email protected]> * release notes updated * version updated * Add error messages for task completion where required * version updated * release notes updated with version number * Make potential fix * Revert unneccessary changes * Update form-value.service.ts --------- Co-authored-by: OgunyemiO <[email protected]> Co-authored-by: RiteshHMCTS <[email protected]> Co-authored-by: Ritesh Dsouza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-1038
Change description
Does this PR introduce a breaking change? (check one with "x")