Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case flags v2 based on master #1548

Closed
wants to merge 128 commits into from

Conversation

johnbenjamin-hmcts
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EUI-7243

Change description

Case flags v2 - Reasonable adjustments

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

DavidJayakumar and others added 7 commits May 17, 2023 11:38
* EUI-8112

* EUI-8112

* bump version

* change responseStatus to responseBy

* Added welsh translation for query list component

* recursive lastMessage

* bump version

* fix linting and console.log

* Add sorting

* Review comment

* Update version

* Add test

* fix lint

---------

Co-authored-by: Matei Baciu <[email protected]>
* Initial commit for Case Flags v2 feature

Case Flags v2 feature also known as "Reasonable Adjustments".

* EUI-7347/EUI-7570: Case Flags v2 - New "Not approved" status (#1332)

Support display of new "Not approved" status for Case Flags.

* Feature/e UI 7349 (#1334)

* EUI-7348

* export pipe + bump version

* remove fieldset

* address pr comments

* bump version

* EUI-7349

* Revert "Feature/e UI 7349 (#1334)" (#1337)

This reverts commit 75fd8a085fa951ac834fa2e783c40ccea5750986.

* EUI-7348 (#1328)

* EUI-7348

* export pipe + bump version

* remove fieldset

* address pr comments

* bump version

* EUI-7688: Case Flags v2 - Support multiple Case Flags tabs (#1344)

Ensure the `ReadCaseFlagFieldComponent` can support multiple Case Flags tabs (each with their own unique `FlagLauncher` field instance) and display the correct flags-related data for each one.

* fix build error

* bump version

* Feature/e UI 6199 (#1354)

* EUI-6199

* EUI-6199

* small change

* Delete case-edit-form.service.ts

* addressed PR comments

* fix type error

* fix pageLocation being hardcoded

* fix comments

* EUI-7350: Case Flags v2 - Confirm flag status step (#1370)

Initial implementation of the "Confirm the status of the flag" step of Create Case Flag journey.

* EUI-7367 (#1366)

* EUI-7367

* mistake EUI-7367

* bump package version

* EUI-7362: Case Flags v2 - "Request support" and "Manage support" legal rep journeys (#1371)

Ensure correct titles and captions are shown for "Request support" and "Manage support" journeys for legal reps.

* EUI-7726 (#1358)

* EUI-7726

* 7726

* replace async with waitForAsync

* QA comments

* Feature/e UI 7349 (#1338)

* EUI-6199

* EUI-6199

* small change

* Delete case-edit-form.service.ts

* addressed PR comments

* fix type error

* fix pageLocation being hardcoded

* fix comments

* EUI-7349

* Feature/e UI 7349 (#1334)

* EUI-7348

* export pipe + bump version

* remove fieldset

* address pr comments

* bump version

* EUI-7349

* fix maxlength issue

* EUI-7349

* remove text

* readonly for both welsh fields

* remove console.log

* fix conflicts

* EUI-7349

* bump version

* EUI-7361 (#1361)

* bump ccd version

* fix  tests

* addressed QA comments

* fix type in search language interpreter

* fix test

* Feature/e UI 7365 (#1363)

* EUI-7726

* 7726

* replace async with waitForAsync

* EUI-7365

* Feature/e UI 7364 (#1367)

* EUI-7367

* EUI-7364

* added case-flag-refdata service as well

* bump version

* bump package version

* EUI-7362: Case Flags v2 - "Request support" and "Manage support" legal rep journeys (#1371)

Ensure correct titles and captions are shown for "Request support" and "Manage support" journeys for legal reps.

* fix search language interpreter test

* bump version

* add text back

* comment issue

* bump version package.json

---------

Co-authored-by: Daniel Lam (A533913) <[email protected]>

* Feature/e UI 7368 (#1369)

* EUI-7368

* EUI-7368

* remove hardcoded event id

* bump ccd toolkit version

* EUI-7362: Case Flags v2 - "Request support" and "Manage support" legal rep journeys (#1371)

Ensure correct titles and captions are shown for "Request support" and "Manage support" journeys for legal reps.

* case-flags-check-your-answers

* fix test

---------

Co-authored-by: Daniel Lam (A533913) <[email protected]>

* Feature/e UI 7363 (#1373)

* EUI-7367

* mistake EUI-7367

* EUI-7363

* bump ccd-toolkit version

* fix test

* fix build error

* bump version

* fix small comment

* EUI-7611: Case Flags v2 - Confirm flag status step validation (#1376)

* EUI-7611: Case Flags v2 - Confirm flag status step validation

Add validation to display an error if the user exceeds the 200-character limit for the status reason, or if they do not provide a status reason when "Not approved" is selected.

* Add proper typing to HTML element fields, following suggestion from @MateiHMCTS

* EUI-7777/EUI-7842/EUI-7900: Case Flags v2 - UI amendments for Manage Case Flags pages (#1378)

EUI-7777: Change wording for "translation needed" checkbox on "Update flag" page; EUI-7842: Remove read-only setting from English description and comments boxes on "Add Welsh translation to flag" page; EUI-7900: Add validation to "Update flag" page.

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7932: Case Flags v2 - Add translations to flag step validation

Add validation to display an error if the user exceeds a 200-character limit on any of the descriptions or comments text areas.

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7932: Case Flags v2 - Add translations to flag step validation (#1384)

Add validation to display an error if the user exceeds a 200-character limit on any of the descriptions or comments text areas.

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7354: Case Flags v2 - Filter out "Inactive" and "Not approved" flags from selection (#1387)

Ensure flags with a status of either "Inactive" or "Not approved" are filtered out from display on "Manage case flags" page, so they cannot be selected for update.

* Feature/e UI 7371 (#1389)

* EUI-7371

* bump version

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7929: Case Flags v2 - Set valid status progressions for flag updates

Set the valid flag status options available on the "Update flag" page, based on the current status of the selected flag.

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7351 Reasonable adjustments review flag details screen

* Update write-case-flag-field.component.spec.ts

* EUI-7351 Reasonable adjustments review flag details screen

* EUI-7929: Case Flags v2 - Set valid status progressions for flag updates (#1393)

Set the valid flag status options available on the "Update flag" page, based on the current status of the selected flag.

* Merge from base branch

* EUI-7375 Reasonable adjustments Manage support display CYA page

* EUI-7373

* EUI-7858: Case Flags v2 - Welsh language support (#1400)

* init welsh branch

* EUI-6585

implementing welsh translation pipe

* EUI-6585

using latest version of welsh translation package.

* EUI-6585

translating hints.

* added rpx library and translations

* case-editor, navigation and activity translations

* more changes

* fix cannot bind to aria-describedby errors

* welsh translations

* PR comments

* updated yarn lock

* EUI-6585

adding translation to filters

* EUI-6585 Added rpxTranslate to templates

* Updated test with new MockRpxTranslate pipe

* update test by adding the RpxTranslate pipe

* Release 5.0.15-angular11-updgrade-welsh-release

* Bump version

* loading-snipper RpxTranslationModule added

* Corrected test to pass code coverage

* Updated version 5.0.44-angular11-updgrade-welsh-release-v5

* More test complete to pass coverage

* EUI-7417: Case File View - Disable document move functionality (#1333)

Ensure document move functionality is disabled when Case File View component is in readonly mode.

* Feature/e UI 6572 (#1308)

* addresed comments

* EUI-7160 Hand icon for the folder clicking

* added test

* EUI-6836

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* EUI-7160 Hand icon for the folder clicking

* reverting the fix  EUI-6865 could not submit event

* toolkit version updated

* tag updated

* EUI-6974 V2 Tech ticket for icons

* EUI-6974 V2 Tech ticket for icons

* EUI-5355

* replaced plainToClass in generateTreeData

* replaced other plainToClass in case-file-view-folder

* added type

* fix styling

* fix test error & bump version

* change cdkTreeNodeToggle for CaseFileViewFolder

* fix sonargate issues

* bump version + fix sonargate issue

* EUI-5387

* bump ccd toolkit version

* fix sonar issue

* addresed comments

* added test

* EUI-6836

* fix sonar issue

* EUI-6836

* EUI-6836

* bump ccd-case-ui-toolkit version

* Update yarn.lock

* EUI-7160 Hand icon for the folder clicking

* upgraded version

* updated version to 5.0.27

* EUI-7160 Hand icon for the folder clicking

* Update case-file-view-folder.component.spec.ts

* EUI-7160 Hand icon for the folder clicking

* Add initial component

* add initial component

* EUI-6924

* EUI-7160 Hand icon for the folder clicking

* modify test

* EUI-7210/EUI-7225: Case Flags defect fixes (#1261)

EUI-7210: Fix mapping of case field to flags object to handle `null` or `undefined` CaseField `value` property; EUI-7225: Fix to display party role (if provided) alongside party name for party-level flags options on "Select flag location" page.

* Hotfix/work allocation 3 changes master (#1250)

* Update index.ts

Change to judiciary

* Update package.json

* Update index.spec.ts

* Add updateAttributes method for specific and challenge access request

* make updateAttributes method static

* added accessReason on attributes

* bump version

* changed version name

* Remove mock

* Add check for acess grant

* Add specific reason to request (#1210)

* Update package.json

* Fix old case ref issues

* Fix review comments

* Change package name

* Update package version

* Fix for challanged access

* Bump version

* EUI-6921 Fix old case ref issues (#1219)

* Fix old case ref issues

* Fix review comments

* Change package name

* Update package version

* Fix for challanged access

* Bump version

Co-authored-by: DavidJayakumar <[email protected]>

* Update the request with correct case id

* text update

* text fix

* Clear case details cache on sucess

* EUI-6968

* Remove url fix

* Fix unit test

* Update package version

* bug/EUI-6975 case exclusion

* bug/EUI-6975

* bug/EUI-6975 text fix

* Set basic fields

* fix lint issues

* EUI-6994 (#1236)

* EUI-6994

* updated package version

* Review comments

* review comments

* EUI-6994

* WA feature config changes (#1240)

* WA feature config changes

* Update package.json

* Block non-WA-supported cases on workallocationservice

* Remove logs

* Update event-start.guard.ts

* Test changes

Co-authored-by: Matei Baciu <[email protected]>
Co-authored-by: Matei <[email protected]>
Co-authored-by: DavidJayakumar <[email protected]>
Co-authored-by: David Rajkumar Jayakumar <[email protected]>
Co-authored-by: Kartheek-S <[email protected]>

* lint error

* add menu functionality

* removed extra loop to avoid duplictae message

* Merge from Release

* updated the version

* Integration of case flags and case links

* fixed merge / dependencies and modules

* fixes

* Integration of case flags and case links

* Fixed unit tests

* EUI-6924

* updated the version to 5.0.29-angular11-upgrade

* EUI-6326 - Fixed HTML mark up for Sonar cloud issue

* Feature/e UI 5387 (#1256)

* EUI-6974 V2 Tech ticket for icons

* EUI-6974 V2 Tech ticket for icons

* EUI-5355

* bump package.json version

* replaced plainToClass in generateTreeData

* replaced other plainToClass in case-file-view-folder

* added type

* fix styling

* fix test error & bump version

* change cdkTreeNodeToggle for CaseFileViewFolder

* fix sonargate issues

* bump version + fix sonargate issue

* EUI-5387

* bump ccd toolkit version

* fix sonar issue

* addresed comments

* added test

* typo

* EUI=5387

* bump version

* improve tests

* bump version

* fix text and bump version

* bump version

* bump version

Co-authored-by: John Benjamin <[email protected]>

* EUI-7219 Case name missing

* EUI-7234 linked cases no cases to unlink message

* EUI-5349: Case File View - Media Viewer integration (#1257)

* EUI-5349: Case File View - Media Viewer integration

Incorporate the Media Viewer component into the right-hand pane of the Case File View component.

* Fix unit tests broken by introducing Media Viewer component

Add `StoreModule` and `EffectsModule` imports to affected unit tests; imports required because Media Viewer introduces dependencies on `@ngrx/store` and `@ngrx/effects`.

* update version

* EUI-7219 Case name missing

* EUI-6826: Case File View - display of standard error message (#1253)

Display standard error message if Case File View component is unable to retrieve categories and documents data.

* Merge from linked cases base branch

* fixes after merge

* bump version

* bump version

* fix test + bump version

* update yarn lock

* EUI-7219 Case link unlink case name missing

* EUI-7219 Case link unlink case name missing

* EUI-7219 Case link unlink case name missing

* EUI-7219 Case link unlink case name missing

* Fix merge and build issues

* Release 6.10.0 (#1238)

* Initial commit for Case Flags feature

* EUI-4921: Implement writable Case Flag field (#1013)

* EUI-4921: Implement writable Case Flag field

Initial base implementation to get component interaction with Case Event flow working.

* EUI-4921: Implement writable Case Flag field

Add Case Field component to Case Progress page of Demo app for testing purposes.

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* Revert "EUI-4836 Case flags tab display"

This reverts commit 82db932350a9e36a2b7325184f992889181a6598.

* EUI-4836 Case flags tab display

* Changes after code review

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* Merge pull request #1017 from hmcts/feature/EUI-4836-Case-flags-tab-display

EUI-4836 Case flags tab display and EUI-4897 Banner message display

* Update toolkit version

* EUI-4891 Select flag type page

* EUI-4846 Select language interpreter

* EUI-4846 Select language interpreter

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* Revert "EUI-4891 Select flag type page"

This reverts commit 51cde740886b6b1a85ec21749ad1640ccd3939c2.

* Merge from base branch

* EUI-5257: Extract Case Flags data for use by WriteCaseFlagFieldComponent (#1028)

Extract all flags-related data from the `CaseEventTrigger` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

* EUI-4846 Select language interpreter

* EUI-4846 Select language interpreter

* EUI-5257: Extract Case Flags data for use by ReadCaseFlagFieldComponent (#1030)

* EUI-5257: Extract Case Flags data for use by WriteCaseFlagFieldComponent

Extract all flags-related data from the `CaseEventTrigger` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

* Refactor how we filter out nullable fields

* EUI-5257: Extract Case Flags data for use by ReadCaseFlagFieldComponent

Extract all flags-related data from the `CaseView` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

Co-authored-by: Ronald Mansveld <[email protected]>

* EUI-4846 Select language interpreter

* Merge pull request #1031 from hmcts/feature/EUI-4846-Select-language-interpreter

EUI-4846 select language interpreter

* Changes after code review

* Changes after code review

* Changes after code review

* Changes after code review

* Merge pull request #1025 from hmcts/feature/EUI-4891-Select-flag-type-page

EUI-4891 select flag type page

* Fix banner alignment

* Update select-flag-type.component.html

* Update select-flag-type.component.ts

* Update search-language-interpreter.component.ts

* Update search-language-interpreter.component.spec.ts

* EUI-4846 Changes after code review

* EUI-4838: Create Case Flag - Select Location step

Initial implementation of the flag location step of Create Case Flag journey.

* EUI-4838: Update release notes and package version for pre-release tag

* EUI-4838: Temporarily disable "flag comments" step

* EUI-4897: Case flags tab - banner message display (#1045)

* EUI-4897: Case flags tab - banner message display

Fix case flags tab navigation from message banner.

* Remove CaseField field_type.id equality check

Remove check because checking `field_type.type` is sufficient.

* EUI-4897: Case flags tab - banner message - fix active case flags count

Refactor code for checking for and counting active case flags; change `ReadCaseFlagFieldComponent` to use real data.

* Fix Sonar quality warnings and clean up code

* EUI-5374/EUI-5372: Create Case Flag - Case Event flow error message handling fixes (#1053)

* EUI-5374/EUI-5372: Create Case Flag - Case Event flow error message handling fixes

Fix error message text on clicking "Continue" when creating a Case Flag; fix incorrect handling of display of Case Event flow error message.

* EUI-5374: Create Case Flag - Case Event flow error message

Revision to error message text as suggested by @andywilkinshmcts following review.

* EUI-4851: Create Case Flag - Add Comments step (#1057)

Initial implementation of the add comments step of Create Case Flag journey.

* EUI-5495/EUI-4845: Create Case Flag - Reference Data integration (#1067)

* EUI-5495/EUI-4845: Create Case Flag - Reference Data integration

Integrate "select flag type" step of case flag creation with Reference Data Common API, to retrieve list of flag types.

* CaseFlagRefdataService amendments and cleanup

Remove incorrect setting of HTTP headers and unnecessary error handling. Add unit tests for service.

* Changed service methods to return an Observable of null if URL is not in appConfig

* EUI-5351: Create Case Flag - multi-level flag types (#1074)

Support for display and selection of multi-level flag types at "Select flag type" step.

* EUI-5351: Create Case Flag - multi-level flag types (#1075)

* EUI-5351: Create Case Flag - multi-level flag types

Support for display and selection of multi-level flag types at "Select flag type" step.

* Remove HTML block duplicated in error during merge

* EUI-5385: Create Case Flag - error handling for no party data (#1077)

Error handling for Create Case Flag when case has not been configured for flags.

* EUI-5654: Create Case Flag - "Search for a language interpreter" step integration (#1082)

Integrate with "list of values" data for selected flag types (currently only language ones) from Reference Data, so that this step is displayed only for those particular flag types.

* EUI-4849: Create Case Flag - "Search for a language interpreter" step validation (#1083)

Add validation to language search and manual language inputs of the "Search for a language interpreter" step.

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation (#1086)

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation

Add validation to prevent both language selection and manual language entry at the same time. Also ensure manual language entry value is cleared if "Enter the language manually" checkbox is unchecked.

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation

Fix error styling and HTML structure for page title and hint text.

* EUI-5772: Create Case Flag - "Search for a sign language interpreter" text variation (#1092)

* EUI-5772: Create Case Flag - "Search for a sign language interpreter" text variation

Display page title and hint text variation when selected language flag type is sign language.

* Minor spacing adjustment in HTML template

* EUI-5125 components and bindings implimented (#1087)

* EUI-5125 components and bindings implimented

* implement manage case

* EUI-5125 integration and code finetune

* EUI-5125 optional parameter removed

* EUI-5125 tag created

* EUI-5125 code finetune

* Merge branch 'feature/EUI-4921-4838-create-case-flag-component' of https://github.com/hmcts/ccd-case-ui-toolkit into eui-4895-manage-case-flags-dpaly-seelct-case-flag-page

* implement test

* case flag module export

* aria and id

* EUI-5125 test fix

* EUI-5125 tag created

* EUI-5816/EUI-5808: Manage Case Flags - defect fixes (#1100)

* EUI-5816/EUI-5808: Manage Case Flags - defect fixes

Various defect fixes for the "Select case flag" page (EUI-4895) and "Update flag" page (EUI-5125).

* EUI-4851: Create Case Flag - Add Comments step

Increase flag comments character limit to 200 for consistency with limit on Manage Case Flags "Update flag" page.

Co-authored-by: waynepHMCTS <[email protected]>
Co-authored-by: Daniel Lam (A533913) <[email protected]>

* EUI-5190: Manage Case Flags - "Select case flag" page validation (#1107)

* EUI-5190: Manage Case Flags - "Select case flag" page validation

Add page validation to display an error if the user makes no selection or does not click "Next".

* EUI-4838: Create Case Flag - "Select Location" step unit tests

Add missing unit tests for selecting flag location (similar to Manage Case Flags "Select case flag" page).

* Add fix for unrelated unit tests

Use fake Router.navigate() function to avoid unhandled navigation errors during unit tests.

* EUI-4852: Create Case Flag - summary page (#1118)

First pass at integrating Create Case Flag journey with "Check your answers" stage of the main Case Event flow, and persisting a case flag.

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* Merge pull request #1127 from hmcts/feature/EUI-5848-Case-flag-comments

EUI-5973 Case flag comments

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* Merge pull request #1129 from hmcts/feature/EUI-5848-Flag-comments-mandatory-or-optional

EUI-5848 Flag comments mandatory or optional

* EUI-5342-Update-case-flag

* EUI-5849: Create Case Flag - create case-level flags

Create and display flags at case level.

* EUI-5342-Update-case-flag

* EUI-5342-Update-case-flag

* EUI-5342-Update-case-flag

* EUI-5342-Update-case-flag

* Merge pull request #1136 from hmcts/feature/EUI-5342-Update-case-flag

EUI-5342 Update case flag

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-6070 Update case flag comments always mandatory

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5968: Review Flag Details page - amend layout and content (#1131)

* EUI-5968: Review Flag Details page - amend layout and content

Render an alternate version of the `ReadCaseFlagField` component, showing the new flag details in a summary list, for the "Check your answers" page.

* EUI-6043: Review Flag Details page - fix for "Change" link functionality (#1135)

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5849: Create Case Flag - create case-level flags

Create and display flags at case level.

* EUI-6043: Review Flag Details page - fix for "Change" link functionality

Ensure that any previous case flag being created is removed if the user restarts the "Create Case Flag" journey.

* Fix unit test failures

* EUI-6043: Review Flag Details page - fix for "Continue" button behaviour after clicking "Change"

Ensure FlagLauncher control validity is set correctly to "invalid" when the component is reloaded, by removing it from the parent FormGroup before it is re-registered. Also, refactor code to reintroduce "Next" button to Add Comments and Update Flag pages, remove reference to `WriteCaseFlagFieldComponent` in parent `CaseEditPageComponent`, and instead initiate submit action from the child component.

* Fix linting issue

Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: John Benjamin <[email protected]>

* Add missing change from previous merge

Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: John Benjamin <[email protected]>

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-6080 Amendments to tabular display

* Merge pull request #1141 from hmcts/feature/EUI-6070-Update-case-flag-comments-always-mandatory

EUI-6070 Update case flag comments always mandatory

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-6080 Amendments to tabular display

* EUI-6148/EUI-6155/EUI-6156: Case Flag details persistence fixes

Various bug fixes: EUI-6148 - discarded Case Flag details being persisted when restarting the Create Case Flag or Manage Case Flags journeys; EUI-6155 - change to case flag status is not being reflected; EUI-6156 - last modified date is not being updated when a case flag is updated.

* Merge pull request #1144 from hmcts/feature/EUI-6080-Amendments-to-tabular-display

EUI-6080 Case flags amendments to tabular display

* Merge pull request #1139 from hmcts/feature/EUI-5810-Manage-case-flags-reasonable-adjustment

EUI-5810 Manage case flags reasonable adjustment

* EUI-5872 Select flag type screen display party and case level flags

* EUI-6168: Manage Case Flags - Review Flag Details page

Fix "Review flag details" page to work when updating a flag (Manage Case Flags journey).

* Fix unit test failures and remove redundant import

* Fix unit test failure

* Typo: correct spacing

* EUI-5872 Select flag type screen display party and case level flags

* Merge pull request #1149 from hmcts/bugfix/EUI-6168-manage-case-flags-review-flag-details-page

EUI-6168: Manage Case Flags - Review Flag Details page

* EUI-5872 Select flag type screen display party and case level flags

* EUI-6148/EUI-6155/EUI-6156: Case Flag details persistence fixes (#1146)

Various bug fixes: EUI-6148 - discarded Case Flag details being persisted when restarting the Create Case Flag or Manage Case Flags journeys; EUI-6155 - change to case flag status is not being reflected; EUI-6156 - last modified date is not being updated when a case flag is updated.

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5872 Select flag type screen display party and case level flags

* Merge pull request #1147 from hmcts/feature/EUI-5872-Select-flag-type-screen-display-party-and-case-level-flags

EUI-5872 Select flag type screen display party and case level flags

* Update version number for new tag

Updating to version `4.18.6-case-flags-tag-after-merge-with-release-branch` following update with latest from `Release` branch.

* Fix unit test failure

* EUI-6198: Case Flags table styling changes (#1155)

Increase table caption font size and width of first column.

* EUI-6438: Support for Case Flags fields in Complex and collection fields

Ensure `Flags` fields can be stored and amended as sub-fields of a Complex field, including a collection of that type, and as instances within a collection of type `Flags`.

* Address Sonar quality issues

Remove unused imports and refactor `extractFlagsDataFromCaseField()` and `countActiveFlagsInCaseField()` functions to reduce duplication and complexity.

* Amend package version for tag

* EUI-6551: Fix incorrect alignment of tabular display on tabs (#1169)

Revert erroneous HTML tag change, which causes an alignment anomaly.

* Minor fix-ups

Minor corrections following rebuild of Case Flags feature for `master` branch, from `feature/case-flags` branch targeted at `Release`.

* Update package version

Set package version for pre-release tag.

* Clean-up unit test

Remove unnecessary changes.

* Remove redundant import and test data

* Add missing unit tests

Improve test coverage on Case Flags feature code to at least 80%.

* Fix unit test and invalid package version number

* Fix invalid logic for change of flag status

* EUI-6328-tab-redirection-issue

* avoided init method call twice

* version updated

* reverting the earlier committed code

* remove the empty complex field of previous page

* tests added

* EUI-6718 coverage test added

* version updated

* moved activity polling service to call it once

* version updated

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* version updated

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* fixed deleting complex fields collection items

* fixed version numbers etc

* EUI-6802 CR-52 JOH typeahead

* fixed acidental file push

* removed incorrect import

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* excluding due to edge cases included

* Fix unit test failures

* Fix bug with displaying field labels

Ensure labels are still displayed for regular fields on all other tabs when a Case Flags tab is present.

* bump version

* version changed

* EUI-7116: Fix for empty case-level Flags field missing (#1246)

* EUI-7116: Fix for empty case-level Flags field missing

Fix to ensure a `caseFlags` case-level Flags field with an empty value is retained (empty initially because no party name is required).

* EUI-7116: Fix for empty case-level Flags field missing

Re-tag for release.

* reverting the fix  EUI-6865 could not submit event

* toolkit version updated

* tag updated

* EUI-7210/EUI-7225: Case Flags defect fixes (#1261)

EUI-7210: Fix mapping of case field to flags object to handle `null` or `undefined` CaseField `value` property; EUI-7225: Fix to display party role (if provided) alongside party name for party-level flags options on "Select flag location" page.

* lint error

* removed extra loop to avoid duplictae message

Co-authored-by: Lam <[email protected]>
Co-authored-by: Daniel Lam (A533913) <[email protected]>
Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: Ronald Mansveld <[email protected]>
Co-authored-by: tarikdogan-hmcts <[email protected]>
Co-authored-by: waynepHMCTS <[email protected]>
Co-authored-by: tarik.dogan <[email protected]>
Co-authored-by: Phillip Whitaker <[email protected]>
Co-authored-by: ernestman28 <[email protected]>
Co-authored-by: Phillip Whitaker <[email protected]>

* EUI-7219 Case link unlink case name missing

* EUI-7219 Case link unlink case name missing

* Merge from release

* Update version

* Feature/e UI 6836 (#1258)

* EUI-6974 V2 Tech ticket for icons

* EUI-6974 V2 Tech ticket for icons

* EUI-5355

* bump package.json version

* replaced plainToClass in generateTreeData

* replaced other plainToClass in case-file-view-folder

* added type

* fix styling

* fix test error & bump version

* change cdkTreeNodeToggle for CaseFileViewFolder

* fix sonargate issues

* bump version + fix sonargate issue

* EUI-5387

* bump ccd toolkit version

* fix sonar issue

* addresed comments

* added test

* EUI-6836

* EUI-6974 V2 Tech ticket for icons

* EUI-6974 V2 Tech ticket for icons

* EUI-5355

* replaced plainToClass in generateTreeData

* replaced other plainToClass in case-file-view-folder

* added type

* fix styling

* fix test error & bump version

* change cdkTreeNodeToggle for CaseFileViewFolder

* fix sonargate issues

* bump version + fix sonargate issue

* EUI-5387

* bump ccd toolkit version

* fix sonar issue

* addresed comments

* added test

* EUI-6836

* fix sonar issue

* EUI-6836

* EUI-6836

* bump ccd-case-ui-toolkit version

* fix duplicate imports from merge

* fix merge conflicts

* bump version

Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: Ronald Mansveld <[email protected]>

* Update release notes

* fix issues and bump version

* bump version + fix issues

* Feature/e UI 7166 (#1260)

* EUI-6974 V2 Tech ticket for icons

* EUI-6974 V2 Tech ticket for icons

* EUI-5355

* replaced plainToClass in generateTreeData

* replaced other plainToClass in case-file-view-folder

* added type

* fix styling

* fix test error & bump version

* change cdkTreeNodeToggle for CaseFileViewFolder

* fix sonargate issues

* bump version + fix sonargate issue

* Document count

* added test + bumped version

* fix test and bump version

* fix sonar duplicate code issue

* update yarn.lock

* bump version

* bump version

* fix build error

* bump version

* bump version

* fix test and bump version

* bump version

Co-authored-by: John Benjamin <[email protected]>

* Integration of case flags and case links

* bump version

* EUI-7219 Case name missing unlink journey

* Integration of case flags and case links

* EUI-5358

* FieldsUtils and ReadCaseFlagFieldComponent test complete

* WriteCaseFlagFieldComponent test reinstated

* upgrade version number to 5.0.30-angular11-upgrade

* Fix for failing ngbuild.

* EUI-7327 Flickering issue

* Hotfix rollup branch for Case Flags fixes for EUI-7236, EUI-7272, and EUI-7265.

* EUI-7236: Case Flags defect fix (#1266)

* Initial commit for Case Flags feature

* EUI-4921: Implement writable Case Flag field (#1013)

* EUI-4921: Implement writable Case Flag field

Initial base implementation to get component interaction with Case Event flow working.

* EUI-4921: Implement writable Case Flag field

Add Case Field component to Case Progress page of Demo app for testing purposes.

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* Revert "EUI-4836 Case flags tab display"

This reverts commit 82db932350a9e36a2b7325184f992889181a6598.

* EUI-4836 Case flags tab display

* Changes after code review

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* Merge pull request #1017 from hmcts/feature/EUI-4836-Case-flags-tab-display

EUI-4836 Case flags tab display and EUI-4897 Banner message display

* Update toolkit version

* EUI-4891 Select flag type page

* EUI-4846 Select language interpreter

* EUI-4846 Select language interpreter

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* Revert "EUI-4891 Select flag type page"

This reverts commit 51cde740886b6b1a85ec21749ad1640ccd3939c2.

* Merge from base branch

* EUI-5257: Extract Case Flags data for use by WriteCaseFlagFieldComponent (#1028)

Extract all flags-related data from the `CaseEventTrigger` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

* EUI-4846 Select language interpreter

* EUI-4846 Select language interpreter

* EUI-5257: Extract Case Flags data for use by ReadCaseFlagFieldComponent (#1030)

* EUI-5257: Extract Case Flags data for use by WriteCaseFlagFieldComponent

Extract all flags-related data from the `CaseEventTrigger` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

* Refactor how we filter out nullable fields

* EUI-5257: Extract Case Flags data for use by ReadCaseFlagFieldComponent

Extract all flags-related data from the `CaseView` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

Co-authored-by: Ronald Mansveld <[email protected]>

* EUI-4846 Select language interpreter

* Merge pull request #1031 from hmcts/feature/EUI-4846-Select-language-interpreter

EUI-4846 select language interpreter

* Changes after code review

* Changes after code review

* Changes after code review

* Changes after code review

* Merge pull request #1025 from hmcts/feature/EUI-4891-Select-flag-type-page

EUI-4891 select flag type page

* Fix banner alignment

* Update select-flag-type.component.html

* Update select-flag-type.component.ts

* Update search-language-interpreter.component.ts

* Update search-language-interpreter.component.spec.ts

* EUI-4846 Changes after code review

* EUI-4838: Create Case Flag - Select Location step

Initial implementation of the flag location step of Create Case Flag journey.

* EUI-4838: Update release notes and package version for pre-release tag

* EUI-4838: Temporarily disable "flag comments" step

* EUI-4897: Case flags tab - banner message display (#1045)

* EUI-4897: Case flags tab - banner message display

Fix case flags tab navigation from message banner.

* Remove CaseField field_type.id equality check

Remove check because checking `field_type.type` is sufficient.

* EUI-4897: Case flags tab - banner message - fix active case flags count

Refactor code for checking for and counting active case flags; change `ReadCaseFlagFieldComponent` to use real data.

* Fix Sonar quality warnings and clean up code

* EUI-5374/EUI-5372: Create Case Flag - Case Event flow error message handling fixes (#1053)

* EUI-5374/EUI-5372: Create Case Flag - Case Event flow error message handling fixes

Fix error message text on clicking "Continue" when creating a Case Flag; fix incorrect handling of display of Case Event flow error message.

* EUI-5374: Create Case Flag - Case Event flow error message

Revision to error message text as suggested by @andywilkinshmcts following review.

* EUI-4851: Create Case Flag - Add Comments step (#1057)

Initial implementation of the add comments step of Create Case Flag journey.

* EUI-5495/EUI-4845: Create Case Flag - Reference Data integration (#1067)

* EUI-5495/EUI-4845: Create Case Flag - Reference Data integration

Integrate "select flag type" step of case flag creation with Reference Data Common API, to retrieve list of flag types.

* CaseFlagRefdataService amendments and cleanup

Remove incorrect setting of HTTP headers and unnecessary error handling. Add unit tests for service.

* Changed service methods to return an Observable of null if URL is not in appConfig

* EUI-5351: Create Case Flag - multi-level flag types (#1074)

Support for display and selection of multi-level flag types at "Select flag type" step.

* EUI-5351: Create Case Flag - multi-level flag types (#1075)

* EUI-5351: Create Case Flag - multi-level flag types

Support for display and selection of multi-level flag types at "Select flag type" step.

* Remove HTML block duplicated in error during merge

* EUI-5385: Create Case Flag - error handling for no party data (#1077)

Error handling for Create Case Flag when case has not been configured for flags.

* EUI-5654: Create Case Flag - "Search for a language interpreter" step integration (#1082)

Integrate with "list of values" data for selected flag types (currently only language ones) from Reference Data, so that this step is displayed only for those particular flag types.

* EUI-4849: Create Case Flag - "Search for a language interpreter" step validation (#1083)

Add validation to language search and manual language inputs of the "Search for a language interpreter" step.

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation (#1086)

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation

Add validation to prevent both language selection and manual language entry at the same time. Also ensure manual language entry value is cleared if "Enter the language manually" checkbox is unchecked.

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation

Fix error styling and HTML structure for page title and hint text.

* EUI-5772: Create Case Flag - "Search for a sign language interpreter" text variation (#1092)

* EUI-5772: Create Case Flag - "Search for a sign language interpreter" text variation

Display page title and hint text variation when selected language flag type is sign language.

* Minor spacing adjustment in HTML template

* EUI-5125 components and bindings implimented (#1087)

* EUI-5125 components and bindings implimented

* implement manage case

* EUI-5125 integration and code finetune

* EUI-5125 optional parameter removed

* EUI-5125 tag created

* EUI-5125 code finetune

* Merge branch 'feature/EUI-4921-4838-create-case-flag-component' of https://github.com/hmcts/ccd-case-ui-toolkit into eui-4895-manage-case-flags-dpaly-seelct-case-flag-page

* implement test

* case flag module export

* aria and id

* EUI-5125 test fix

* EUI-5125 tag created

* EUI-5816/EUI-5808: Manage Case Flags - defect fixes (#1100)

* EUI-5816/EUI-5808: Manage Case Flags - defect fixes

Various defect fixes for the "Select case flag" page (EUI-4895) and "Update flag" page (EUI-5125).

* EUI-4851: Create Case Flag - Add Comments step

Increase flag comments character limit to 200 for consistency with limit on Manage Case Flags "Update flag" page.

Co-authored-by: waynepHMCTS <[email protected]>
Co-authored-by: Daniel Lam (A533913) <[email protected]>

* EUI-5190: Manage Case Flags - "Select case flag" page validation (#1107)

* EUI-5190: Manage Case Flags - "Select case flag" page validation

Add page validation to display an error if the user makes no selection or does not click "Next".

* EUI-4838: Create Case Flag - "Select Location" step unit tests

Add missing unit tests for selecting flag location (similar to Manage Case Flags "Select case flag" page).

* Add fix for unrelated unit tests

Use fake Router.navigate() function to avoid unhandled navigation errors during unit tests.

* EUI-4852: Create Case Flag - summary page (#1118)

First pass at integrating Create Case Flag journey with "Check your answers" stage of the main Case Event flow, and persisting a case flag.

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Case flag comments

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* Merge pull request #1127 from hmcts/feature/EUI-5848-Case-flag-comments

EUI-5973 Case flag comments

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* Merge pull request #1129 from hmcts/feature/EUI-5848-Flag-comments-mandatory-or-optional

EUI-5848 Flag comments mandatory or optional

* EUI-5342-Update-case-flag

* EUI-5849: Create Case Flag - create case-level flags

Create and display flags at case level.

* EUI-5342-Update-case-flag

* EUI-5342-Update-case-flag

* EUI-5342-Update-case-flag

* EUI-5342-Update-case-flag

* Merge pull request #1136 from hmcts/feature/EUI-5342-Update-case-flag

EUI-5342 Update case flag

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-6070 Update case flag comments always mandatory

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5294 Remove blank space from case flags tab

* EUI-5968: Review Flag Details page - amend layout and content (#1131)

* EUI-5968: Review Flag Details page - amend layout and content

Render an alternate version of the `ReadCaseFlagField` component, showing the new flag details in a summary list, for the "Check your answers" page.

* EUI-6043: Review Flag Details page - fix for "Change" link functionality (#1135)

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5848 Flag comments mandatory or optional

* EUI-5849: Create Case Flag - create case-level flags

Create and display flags at case level.

* EUI-6043: Review Flag Details page - fix for "Change" link functionality

Ensure that any previous case flag being created is removed if the user restarts the "Create Case Flag" journey.

* Fix unit test failures

* EUI-6043: Review Flag Details page - fix for "Continue" button behaviour after clicking "Change"

Ensure FlagLauncher control validity is set correctly to "invalid" when the component is reloaded, by removing it from the parent FormGroup before it is re-registered. Also, refactor code to reintroduce "Next" button to Add Comments and Update Flag pages, remove reference to `WriteCaseFlagFieldComponent` in parent `CaseEditPageComponent`, and instead initiate submit action from the child component.

* Fix linting issue

Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: John Benjamin <[email protected]>

* Add missing change from previous merge

Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: John Benjamin <[email protected]>

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-6080 Amendments to tabular display

* Merge pull request #1141 from hmcts/feature/EUI-6070-Update-case-flag-comments-always-mandatory

EUI-6070 Update case flag comments always mandatory

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-6080 Amendments to tabular display

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5810 Manage case flags reasonable adjustment

* EUI-5810 Manage case flags reasonable adjustment

* EUI-6080 Amendments to tabular display

* EUI-6148/EUI-6155/EUI-6156: Case Flag details persistence fixes

Various bug fixes: EUI-6148 - discarded Case Flag details being persisted when restarting the Create Case Flag or Manage Case Flags journeys; EUI-6155 - change to case flag status is not being reflected; EUI-6156 - last modified date is not being updated when a case flag is updated.

* Merge pull request #1144 from hmcts/feature/EUI-6080-Amendments-to-tabular-display

EUI-6080 Case flags amendments to tabular display

* Merge pull request #1139 from hmcts/feature/EUI-5810-Manage-case-flags-reasonable-adjustment

EUI-5810 Manage case flags reasonable adjustment

* EUI-5872 Select flag type screen display party and case level flags

* EUI-6168: Manage Case Flags - Review Flag Details page

Fix "Review flag details" page to work when updating a flag (Manage Case Flags journey).

* Fix unit test failures and remove redundant import

* Fix unit test failure

* Typo: correct spacing

* EUI-5872 Select flag type screen display party and case level flags

* Merge pull request #1149 from hmcts/bugfix/EUI-6168-manage-case-flags-review-flag-details-page

EUI-6168: Manage Case Flags - Review Flag Details page

* EUI-5872 Select flag type screen display party and case level flags

* EUI-6148/EUI-6155/EUI-6156: Case Flag details persistence fixes (#1146)

Various bug fixes: EUI-6148 - discarded Case Flag details being persisted when restarting the Create Case Flag or Manage Case Flags journeys; EUI-6155 - change to case flag status is not being reflected; EUI-6156 - last modified date is not being updated when a case flag is updated.

* EUI-5872 Select flag type screen display party and case level flags

* EUI-5872 Select flag type screen display party and case level flags

* Merge pull request #1147 from hmcts/feature/EUI-5872-Select-flag-type-screen-display-party-and-case-level-flags

EUI-5872 Select flag type screen display party and case level flags

* Update version number for new tag

Updating to version `4.18.6-case-flags-tag-after-merge-with-release-branch` following update with latest from `Release` branch.

* Fix unit test failure

* EUI-6198: Case Flags table styling changes (#1155)

Increase table caption font size and width of first column.

* EUI-6438: Support for Case Flags fields in Complex and collection fields

Ensure `Flags` fields can be stored and amended as sub-fields of a Complex field, including a collection of that type, and as instances within a collection of type `Flags`.

* Address Sonar quality issues

Remove unused imports and refactor `extractFlagsDataFromCaseField()` and `countActiveFlagsInCaseField()` functions to reduce duplication and complexity.

* Amend package version for tag

* EUI-6551: Fix incorrect alignment of tabular display on tabs (#1169)

Revert erroneous HTML tag change, which causes an alignment anomaly.

* Minor fix-ups

Minor corrections following rebuild of Case Flags feature for `master` branch, from `feature/case-flags` branch targeted at `Release`.

* Update package version

Set package version for pre-release tag.

* Clean-up unit test

Remove unnecessary changes.

* Remove redundant import and test data

* Add missing unit tests

Improve test coverage on Case Flags feature code to at least 80%.

* Fix unit test and invalid package version number

* Fix invalid logic for change of flag status

* EUI-6328-tab-redirection-issue

* avoided init method call twice

* version updated

* reverting the earlier committed code

* remove the empty complex field of previous page

* tests added

* EUI-6718 coverage test added

* version updated

* moved activity polling service to call it once

* version updated

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* version updated

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* fixed deleting complex fields collection items

* fixed version numbers etc

* EUI-6802 CR-52 JOH typeahead

* fixed acidental file push

* removed incorrect import

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* EUI-6802 CR-52 JOH typeahead

* excluding due to edge cases included

* Fix unit test failures

* Fix bug with displaying field labels

Ensure labels are still displayed for regular fields on all other tabs when a Case Flags tab is present.

* bump version

* version changed

* EUI-7116: Fix for empty case-level Flags field missing (#1246)

* EUI-7116: Fix for empty case-level Flags field missing

Fix to ensure a `caseFlags` case-level Flags field with an empty value is retained (empty initially because no party name is required).

* EUI-7116: Fix for empty case-level Flags field missing

Re-tag for release.

* reverting the fix  EUI-6865 could not submit event

* toolkit version updated

* tag updated

* EUI-7210/EUI-7225: Case Flags defect fixes (#1261)

EUI-7210: Fix mapping of case field to flags object to handle `null` or `undefined` CaseField `value` property; EUI-7225: Fix to display party role (if provided) alongside party name for party-level flags options on "Select flag location" page.

* lint error

* removed extra loop to avoid duplictae message

* EUI-7236: Case Flags defect fix

Fix to ensure function for deleting field values can handle collections of object values.

Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: John Benjamin <[email protected]>
Co-authored-by: Ronald Mansveld <[email protected]>
Co-authored-by: tarikdogan-hmcts <[email protected]>
Co-authored-by: waynepHMCTS <[email protected]>
Co-authored-by: RiteshHMCTS <[email protected]>
Co-authored-by: tarik.dogan <[email protected]>
Co-authored-by: RiteshHMCTS <[email protected]>
Co-authored-by: Phillip Whitaker <[email protected]>
Co-authored-by: ernestman28 <[email protected]>
Co-authored-by: Phillip Whitaker <[email protected]>

* EUI-7272: Case Flags defect fix (#1269)

* Initial commit for Case Flags feature

* EUI-4921: Implement writable Case Flag field (#1013)

* EUI-4921: Implement writable Case Flag field

Initial base implementation to get component interaction with Case Event flow working.

* EUI-4921: Implement writable Case Flag field

Add Case Field component to Case Progress page of Demo app for testing purposes.

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-897 Banner message display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* EUI-4836 Case flags tab display

* Revert "EUI-4836 Case flags tab display"

This reverts commit 82db932350a9e36a2b7325184f992889181a6598.

* EUI-4836 Case flags tab display

* Changes after code review

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* Merge pull request #1017 from hmcts/feature/EUI-4836-Case-flags-tab-display

EUI-4836 Case flags tab display and EUI-4897 Banner message display

* Update toolkit version

* EUI-4891 Select flag type page

* EUI-4846 Select language interpreter

* EUI-4846 Select language interpreter

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* EUI-4891 Select flag type page

* Revert "EUI-4891 Select flag type page"

This reverts commit 51cde740886b6b1a85ec21749ad1640ccd3939c2.

* Merge from base branch

* EUI-5257: Extract Case Flags data for use by WriteCaseFlagFieldComponent (#1028)

Extract all flags-related data from the `CaseEventTrigger` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

* EUI-4846 Select language interpreter

* EUI-4846 Select language interpreter

* EUI-5257: Extract Case Flags data for use by ReadCaseFlagFieldComponent (#1030)

* EUI-5257: Extract Case Flags data for use by WriteCaseFlagFieldComponent

Extract all flags-related data from the `CaseEventTrigger` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

* Refactor how we filter out nullable fields

* EUI-5257: Extract Case Flags data for use by ReadCaseFlagFieldComponent

Extract all flags-related data from the `CaseView` object in the snapshot data and map to a collection of `Flags` objects and their `FlagDetail` children.

Co-authored-by: Ronald Mansveld <[email protected]>

* EUI-4846 Select language interpreter

* Merge pull request #1031 from hmcts/feature/EUI-4846-Select-language-interpreter

EUI-4846 select language interpreter

* Changes after code review

* Changes after code review

* Changes after code review

* Changes after code review

* Merge pull request #1025 from hmcts/feature/EUI-4891-Select-flag-type-page

EUI-4891 select flag type page

* Fix banner alignment

* Update select-flag-type.component.html

* Update select-flag-type.component.ts

* Update search-language-interpreter.component.ts

* Update search-language-interpreter.component.spec.ts

* EUI-4846 Changes after code review

* EUI-4838: Create Case Flag - Select Location step

Initial implementation of the flag location step of Create Case Flag journey.

* EUI-4838: Update release notes and package version for pre-release tag

* EUI-4838: Temporarily disable "flag comments" step

* EUI-4897: Case flags tab - banner message display (#1045)

* EUI-4897: Case flags tab - banner message display

Fix case flags tab navigation from message banner.

* Remove CaseField field_type.id equality check

Remove check because checking `field_type.type` is sufficient.

* EUI-4897: Case flags tab - banner message - fix active case flags count

Refactor code for checking for and counting active case flags; change `ReadCaseFlagFieldComponent` to use real data.

* Fix Sonar quality warnings and clean up code

* EUI-5374/EUI-5372: Create Case Flag - Case Event flow error message handling fixes (#1053)

* EUI-5374/EUI-5372: Create Case Flag - Case Event flow error message handling fixes

Fix error message text on clicking "Continue" when creating a Case Flag; fix incorrect handling of display of Case Event flow error message.

* EUI-5374: Create Case Flag - Case Event flow error message

Revision to error message text as suggested by @andywilkinshmcts following review.

* EUI-4851: Create Case Flag - Add Comments step (#1057)

Initial implementation of the add comments step of Create Case Flag journey.

* EUI-5495/EUI-4845: Create Case Flag - Reference Data integration (#1067)

* EUI-5495/EUI-4845: Create Case Flag - Reference Data integration

Integrate "select flag type" step of case flag creation with Reference Data Common API, to retrieve list of flag types.

* CaseFlagRefdataService amendments and cleanup

Remove incorrect setting of HTTP headers and unnecessary error handling. Add unit tests for service.

* Changed service methods to return an Observable of null if URL is not in appConfig

* EUI-5351: Create Case Flag - multi-level flag types (#1074)

Support for display and selection of multi-level flag types at "Select flag type" step.

* EUI-5351: Create Case Flag - multi-level flag types (#1075)

* EUI-5351: Create Case Flag - multi-level flag types

Support for display and selection of multi-level flag types at "Select flag type" step.

* Remove HTML block duplicated in error during merge

* EUI-5385: Create Case Flag - error handling for no party data (#1077)

Error handling for Create Case Flag when case has not been configured for flags.

* EUI-5654: Create Case Flag - "Search for a language interpreter" step integration (#1082)

Integrate with "list of values" data for selected flag types (currently only language ones) from Reference Data, so that this step is displayed only for those particular flag types.

* EUI-4849: Create Case Flag - "Search for a language interpreter" step validation (#1083)

Add validation to language search and manual language inputs of the "Search for a language interpreter" step.

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation (#1086)

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation

Add validation to prevent both language selection and manual language entry at the same time. Also ensure manual language entry value is cleared if "Enter the language manually" checkbox is unchecked.

* EUI-5657: Create Case Flag - "Search for a language interpreter" step validation

Fix error styling and HTML structure for page title and hint text.

* EUI-5772: Create Case Flag - "Search for a sign language interpreter" text variation (#1092)

* EUI-5772: Create Case Flag - "Search for a sign language interpreter" text variation

Display page title and hint text variation when selected language flag type is sign language.

* Minor spacing adjustment in HTML template

* EUI-5125 components and bindings implimented (#1087)

* EUI-5125 components and bindings implimented

* implement manage case

* EUI-5125 integration and code finetune

* EUI-5125 optional parameter removed

* EUI-5125 tag created

* EUI-5125 code finetune

* Merge branch 'feature/EUI-4921-4838-create-case-flag-component' of https://github.com/hmcts/ccd-case-ui-toolkit into eui-4895-manage-case-flags-dpaly-seelct-case-flag-page

* implement test

* case flag module export

* aria and id

* EUI-5125 test fix

* EUI-5125 tag created

* EUI-5816/EUI-5808: Manage Case Flags - defect fixes (#1100)

* EUI-5816/EUI-5808: Manage Case Flags - defect fixes

Various defect fixes for the "Select case flag" page (EUI-4895) and "Update flag" page (EUI-5125).

* EUI-4851: Create Case Flag - Add Comments step

Increase flag comments character limit to 200 for consistency with limit on Manage Case Flags "Update flag" page.

Co-authored-by: waynepHMCTS <[email protected]>
Co-authored-by: Daniel Lam (A533913) <[email protected]>

* EUI-5190: Manage Case Flags - "Select case flag" page validation (#1107)

* EUI-5190: Manage Case Flags - "Select case flag" page validation

Add page validation to display an error if the user makes no selection or d…
Daniel-Lam
Daniel-Lam previously approved these changes Aug 21, 2023
Copy link
Contributor

@Daniel-Lam Daniel-Lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbenjamin-hmcts - approved, based on looking at the commit history

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

88.6% 88.6% Coverage
0.0% 0.0% Duplication

@Daniel-Lam
Copy link
Contributor

Closing this PR because it is long out-of-date.

@Daniel-Lam Daniel-Lam closed this Feb 9, 2024
@Daniel-Lam Daniel-Lam deleted the Case-flags-v2-based-on-master branch February 9, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants