Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change searching method #239

Open
hilmanski opened this issue Aug 31, 2022 · 8 comments
Open

Change searching method #239

hilmanski opened this issue Aug 31, 2022 · 8 comments

Comments

@hilmanski
Copy link
Owner

hilmanski commented Aug 31, 2022

Right now we're searching through javascript that only valid for one page.
As the item grows, we need to make a pagination to not load all items at once.

For that pagination,
we'll need a new search/filter method.
[might be change not live search anymore as we have now]

Watchout there are 3 pages will be affected:
index / tag(list) / random

@hilmanski
Copy link
Owner Author

potential solution: https://onebite.dev/add-live-search-in-hugo-website/

@Ravina-Deogadkar
Copy link

Can I take this task?

@hilmanski
Copy link
Owner Author

HI @Ravina-Deogadkar thanks for your willingness to do this task. Appreciate it.
Here's what I planned to do:

  • Pagination limit to 100
  • We can get 'API' data from /stuff/index.json
  • Search method become a 'HTML form' that submit request to go to another page
  • The 'search page' will be like on this link 'https://onebite.dev/add-live-search-in-hugo-website/'. EIther using vanillaJS if you comfortable with it or vueJS, like what's used in the link.
  • Cards template will have the same design as we have now.

Thanks. LMK if you have a suggestion / better idea

@Ravina-Deogadkar
Copy link

Sure, I have never used vanillaJS before but I can check if it works. Can you assign the issue to me?

@Ravina-Deogadkar
Copy link

I am getting an error while cloning in windows 11.
image

@hilmanski
Copy link
Owner Author

Looks like Windows have issue with "|" as a file name.
I've update(delete) that file since its not active anymore.
You can try again after pull the latest change

@arpanbiki
Copy link

please assign me this sir.

@hilmanski
Copy link
Owner Author

Hi @Ravina-Deogadkar are you still working on this?
If no answer after 2 days, I'll assume you stopped working on it. Thanks!

need to verify since @arpanbiki want to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants