Resume from hibernation turns off battery threshold at 80 percent

[whatnameisit]

On normal use, AsusSMC 1.4.0+ caps the battery level at 80 percent if Battery Health in Energy Saver is toggled on.
When the machine resumes from hibernation, the threshold is ignored and the battery keeps on charging until 100 percent.
I'm not good with logging (and about zero knowledge in coding), so if anyone could tell me how, I'll collect the logs and upload them here.

IOReg: Battery Conservation Mode is marked true in ATK-AsusSMC
MacBook Pro.zip
Asus Dmesg output shows battery conservation mode true
Asus.log.zip
Hibernation logs Hibern hibern HBFX
hibernation.zip

[Ubsefor]

This feature shouldn't work at all on non-apple hardware. I tried to use it for a bit and noticed that my battery doesn't charge correctly with this turned on: battery dies at 30-40% immediately.

I don't know whether you have the same issue or not, but I suggest at least checking it out.

[whatnameisit]

I'm not sure we are on the same issue. By "this feature," did you mean battery threshold on hibernation or just the battery threshold?
Hibernation works with HibernationFixup.kext and battery threshold works with AsusSMC.kext.
When both kexts are used together, battery threshold is ignored when resuming from hibernation. A simple reboot makes the limit to kick in and prevent the charging above 80 percent again.
I don't remember experiencing the laptop shutting down at 30-40 percent battery level, if that's what you mean by battery dies at 30-40% immediately. I'm pretty sure there were times the battery level was below 25 percent and it charged fine with the battery threshold feature on.
Since you commented, do you know how to debug or collect logs on my issue?

[whatnameisit]

I fried my laptop's motherboard and sold it for 100000 won. I won't close this issue though because it's a real one.

[yjmd2222]

1.4.0
Support battery charge threshold found on new laptops (charging stops at 80%). Can be disabled by turning off Battery Health in Energy Saver.

Can it really be turned off in Energy Saver in Catalina?

AsusSMC/AsusSMC/AsusSMC.cpp

Lines 379 to 390 in c15d2f2

	void AsusSMC::initBattery() {
	// Battery Health was introduced in 10.15.5
	// Check if we're on 10.15.5+
	if (getKernelVersion() < KernelVersion::Catalina || (getKernelVersion() == KernelVersion::Catalina && getKernelMinorVersion() < 5)) {
	return;
	}
	isBatteryRSOCAvailable = wmi_dev_is_present(ASUS_WMI_DEVID_RSOC);
	if (isBatteryRSOCAvailable) {
	toggleBatteryConservativeMode(true);
	}
	}

AsusSMC/AsusSMC/AsusSMC.cpp

Lines 604 to 616 in c15d2f2

	void AsusSMC::toggleBatteryConservativeMode(bool state) {
	if (!isBatteryRSOCAvailable) {
	DBGLOG("batt", "RSOC unavailable");
	return;
	}
	if (wmi_evaluate_method(ASUS_WMI_METHODID_DEVS, ASUS_WMI_DEVID_RSOC, state ? 80 : 100) != 1) {
	SYSLOG("batt", "Failed to %s battery conservative mode", state ? "enable" : "disable");
	} else {
	DBGLOG("batt", "Battery conservative mode is %s", state ? "enabled" : "disabled");
	setProperty("BatteryConservativeMode", state);
	}
	}

AsusSMC/AsusSMC/AsusSMC.cpp

Lines 871 to 875 in c15d2f2

	if (isBatteryRSOCAvailable) {
	VirtualSMCAPI::addKey(KeyBDVT, vsmcPlugin.data, VirtualSMCAPI::valueWithFlag(
	false, new BDVT(this),
	SMC_KEY_ATTRIBUTE_READ | SMC_KEY_ATTRIBUTE_WRITE | SMC_KEY_ATTRIBUTE_ATOMIC));
	}

I don't see any reading from Battery Health that is used to turn it off.

Anyways, I think the original issue can be resolved if the kext calls the method on resume. I don't know the details, but hibernation is similar to shutdown, which if true will reset EC to original, non-conservation mode. A quick check is to call the corresponding ACPI method EC0.SRSC (0) on resume with ACPIDebug.kext.

[yjmd2222]

I'm blind

AsusSMC/AsusSMC/KeyImplementations.cpp

Lines 55 to 67 in c15d2f2

	SMC_RESULT BDVT::update(const SMC_DATA *src) {
	bool state = false;
	lilu_os_memcpy(&state, src, size);
	// BDVT is 00 when battery health is enabled and 01 when disabled
	state = !state;
	AsusSMC *drv = OSDynamicCast(AsusSMC, dst);
	drv->toggleBatteryConservativeMode(state);
	lilu_os_memcpy(data, src, size);
	return SmcSuccess;
	}

I can't get the machine to hibernate, so can't test it. Tried: HibernateMode=Auto/RTC/NVRAM, ThirdPartyDrives=True, HibernationFixup.kext=enabled, and hibernatemode=25/3.
If anyone has step-by-step directions to enable hibernation, please share, because I might have missed something.

[yjmd2222]

Upon resume from hibernation, the battery does charge above the threshold. Then I set the threshold with ACPIDebug.

[ 1267.932184]: [ACPI Debug]  [ACPI Debug]  "Setting SRSC = 80"

And the battery stops charging.

The icon shows AC is plugged in and not charging.

The kext code can be updated to send battery health command on resume.