-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hard reloads #4183
fix: remove hard reloads #4183
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/web/src/components/Common/Providers/LensSubscriptionsProvider.tsx
Outdated
Show resolved
Hide resolved
@bigint |
Screen.Recording.2023-12-12.at.12.28.58.PM.mov@neo773 It seems like some data are not updated, I guess something to do with apollo garbage collection or evict all cache on logout |
Try with profile on testnet! |
resetPreferences(); | ||
resetFeatureFlags(); | ||
resetPro(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can move all these inside signout method itself so we can just call signout everywhere!
console.log(currentProfile, 'currentProfile'); | ||
console.log(sessionProfileId, 'sessionProfileId'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it
@@ -7,6 +7,10 @@ import urlcat from 'urlcat'; | |||
* @returns The cdn.stamp.fyi URL. | |||
*/ | |||
const getStampFyiURL = (address: string): string => { | |||
// race condition fix when loging out | |||
if (!address) { | |||
return ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can return stamp url with null address aka export const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000';
Expected behaviour is navigating to home page every site does this, |
We mentioned it on the issue 🙇🏼
|
@bigint |
WDYM soft reloading? |
Will it reload the entire app? |
Router refresh, so navigates to same URL |
IMO apollo has lot of utils to clear cache or garbage collect stuffs!
…On Tue, Dec 12, 2023, at 7:09 PM, neo773 wrote:
Router refresh, so navigates to same URL
—
Reply to this email directly, view it on GitHub <#4183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQRXBIDYBREYEWGXC4NLT7LYJBNBFAVCNFSM6AAAAABAQIDASKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGA2TGMBRGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
is this good to review? |
@bigint |
Closing this, we can rethink this later! |
Removes hard reloads in the codebase
hey.mp4
Related issues
Fixes #4182
Type of change
/claim #4182