retrieveLogsAndClear works in constant space

[tau3]

No description provided.

[oluwasayo]

Thanks for the contribution @tau3! There's a constraint by Cloudwatch that log events must be ordered sequentially by timestamp.

[tau3]

oh, i thought the queue was naturally ordered. PR will improved then)

[oluwasayo]

It's a concurrent queue being written to by many producers. Take for example an application server servicing multiple users concurrently on different worker threads.

[tau3]

@oluwasayo please, check

[oluwasayo]

The test still fails. You can run the test locally on your computer with mvn clean test (make sure you update your working copy with the latest base)

[tau3]

i think there are some problems with unit test. junit does not guarantee execution order of unit tests, so relying on "append" test running before "retrieveLogsAndClear" is a mistake. depending on configuration, they can even be executed in separate VMs.

also making one test depend on results of another is a bad practice imo

[oluwasayo]

You're absolutely right about test ordering (at least in most common cases), although that wasn't the reason the tests failed.