diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index 70c62d7186d..00000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,13 +0,0 @@ -# No code owners for all files -* - -# TODO(APP-5348): Remove code owners -# -# This code owners is to make sure that the Visualization team is aware -# of any changes that are going into RC while the team is updating -# the RC implementation in App. -# -# Code owners are no longer needed once RDK uses the shared, -# updated remote control cards from App. For any questions reach -# out to @ethanlook. -web/frontend @ethanlookpotts @micheal-parks @dtcurrie @zaporter-work diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 5ce97f759eb..f8248f8c252 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -21,17 +21,6 @@ updates: assignees: #TODO: make list - stevebriskin - mcvella - - package-ecosystem: "npm" - directory: "web/frontend" - schedule: - interval: "daily" - allow: - - dependency-type: "all" - ignore: - - dependency-name: "proto" # generated proto files - - dependency-name: "*" - update-types: ["version-update:semver-major", "version-update:semver-minor", "version-update:semver-patch"] - open-pull-requests-limit: 0 - package-ecosystem: "github-actions" directory: "/" schedule: diff --git a/.github/workflows/full-static.yml b/.github/workflows/full-static.yml index 3afa947e299..514edc0e820 100644 --- a/.github/workflows/full-static.yml +++ b/.github/workflows/full-static.yml @@ -45,8 +45,6 @@ jobs: with: go-version-file: go.mod - - name: build js - run: make build-web - name: build go shell: bash run: | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index aaf5052e11c..f7369a2d450 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -60,12 +60,6 @@ jobs: secrets: GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }} - npm_publish: - uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main - needs: test - secrets: - NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - license_finder: uses: viamrobotics/rdk/.github/workflows/license_finder.yml@main diff --git a/.github/workflows/npm-bump-version.yml b/.github/workflows/npm-bump-version.yml deleted file mode 100644 index 2b1843e2a2b..00000000000 --- a/.github/workflows/npm-bump-version.yml +++ /dev/null @@ -1,49 +0,0 @@ -name: Bump remote-control Version - -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - -on: - workflow_dispatch: - inputs: - sdk_version: - required: false - type: string - description: | - Typescript SDK Version. - If specified, may be `latest`, `next`, or a specific version. - Defaults to unspecified, which will not update the TypeScript SDK. - - bump: - required: false - type: string - default: "patch" - description: | - RC version to bump to. - May be `patch`, `minor`, `major`, or a specific version. - Defaults to `patch` -jobs: - bump: - name: Bump remote-control Version - runs-on: [ubuntu-latest] - steps: - - name: Check out code - uses: actions/checkout@v3 - - - name: Bump SDK + RC Version - run: | - cd web/frontend - npm install --save --save-exact @viamrobotics/sdk@${{ inputs.sdk_version }} - npm version ${{ inputs.bump }} - - - name: Add + Commit + Open PR - uses: peter-evans/create-pull-request@v3 - with: - commit-message: "[WORKFLOW] Updating remote-control" - branch: "workflow/bump-remote-control/${{ github.ref_name }}" - delete-branch: true - base: ${{ github.ref_name }} - title: Automated remote-control Version Update - body: This is an auto-generated PR to update remote-control package versions. Check the commits to see which repos and commits are responsible for the changes. - assignees: ${{ github.actor }} - reviewers: ${{ github.actor }} diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml deleted file mode 100644 index 3d8c6256f69..00000000000 --- a/.github/workflows/npm-publish.yml +++ /dev/null @@ -1,33 +0,0 @@ -name: NPM Publish - -on: - workflow_call: - secrets: - NPM_TOKEN: - required: true - workflow_dispatch: - -jobs: - publish: - if: github.repository_owner == 'viamrobotics' - runs-on: [ubuntu-latest] - container: - image: ghcr.io/viamrobotics/rdk-devenv:amd64-cache - - steps: - - name: Checkout - uses: actions/checkout@v3 - with: - persist-credentials: false - - - name: Install and Build 🔧 - run: | - npm ci --prefix ./web/frontend --audit=false - npm run build-npm --prefix ./web/frontend - - - name: Publish - uses: JS-DevTools/npm-publish@v2 - with: - token: ${{ secrets.NPM_TOKEN }} - package: ./web/frontend/package.json - access: public diff --git a/.github/workflows/releasecandidate.yml b/.github/workflows/releasecandidate.yml index daa56fe9400..05abaef4b2d 100644 --- a/.github/workflows/releasecandidate.yml +++ b/.github/workflows/releasecandidate.yml @@ -43,12 +43,6 @@ jobs: secrets: GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }} - npm_publish: - uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main - needs: test - secrets: - NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - slack-workflow-status: if: ${{ failure() }} name: Post Workflow Status To Slack diff --git a/.github/workflows/stable.yml b/.github/workflows/stable.yml index 09c585b87be..6cd457b289a 100644 --- a/.github/workflows/stable.yml +++ b/.github/workflows/stable.yml @@ -60,12 +60,6 @@ jobs: secrets: GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }} - npm_publish: - uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main - needs: test - secrets: - NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - slack-workflow-status: if: ${{ failure() }} name: Post Workflow Status To Slack diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0101b25fab4..594898410f4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -202,43 +202,9 @@ jobs: pip install -r cli/test-requirements.txt check-jsonschema --schemafile ./cli/module.schema.json meta2.json - test_web_e2e: - name: Test End-to-End and Web - runs-on: ubuntu-latest - container: ghcr.io/viamrobotics/rdk-devenv:amd64-cache - timeout-minutes: 15 - steps: - - uses: actions/checkout@v3 - with: - ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.ref }} - - - name: Chown - run: chown -R testbot:testbot . - - - name: Verify no uncommitted changes from "make build-web lint-web" - run: | - sudo -Hu testbot bash -lc 'git init && git add . && make build-web lint-web' - GEN_DIFF=$(git status -s) - - if [ -n "$GEN_DIFF" ]; then - echo '"make build-web lint-web" resulted in changes not in git' 1>&2 - git status - exit 1 - fi - - - name: Install dependencies - run: | - apt-get update && apt-get -qy install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb netcat-openbsd lsof - - - name: Run web tests - run: sudo -Hu testbot bash -lc 'make test-web' - - - name: Run e2e tests - run: sudo -Hu testbot bash -lc 'make test-e2e E2E_ARGS="-k"' - test_passing: name: All Tests Passing - needs: [test_go, test_web_e2e, test32, motion_tests] + needs: [test_go, test32, motion_tests] runs-on: [ubuntu-latest] if: always() steps: @@ -246,11 +212,9 @@ jobs: run: | echo Go Unit Tests: ${{ needs.test_go.result }} echo Go 32-bit Tests: ${{ needs.test32.result }} - echo Web/E2E Tests: ${{ needs.test_web_e2e.result }} echo Motion Tests: ${{ needs.motion_tests.result }} [ "${{ needs.test_go.result }}" == "success" ] && \ [ "${{ needs.test32.result }}" == "success" ] && \ - [ "${{ needs.test_web_e2e.result }}" == "success" ] && \ [ "${{ needs.motion_tests.result }}" == "success" ] # Now that RDK is public, can't directly comment without token having full read/write access