Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBC potential bug: lattice coordinates being produced by implicit truncation #759

Open
rupertnash opened this issue Jan 6, 2021 · 1 comment
Assignees
Labels

Comments

@rupertnash
Copy link
Member

I've now disallowed implicit conversions Vector3D -> Vector3D (you can still do this explicitly of course). This has thrown up a number of cases where floating point Vector3D's had been implicitly truncated to integer Vector3Ds, particularly around positions.

I don't know if any of these are bugs.

@rupertnash
Copy link
Member Author

Examples:

auto const iter = globalCoordsToProcMap.find(LatticeVector{barycenter});

return latDat->GetSite(LatticeVector{center}).GetForce();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants