Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimConfig::Save not implemented #703

Open
uschille opened this issue Jun 9, 2017 · 0 comments
Open

SimConfig::Save not implemented #703

uschille opened this issue Jun 9, 2017 · 0 comments

Comments

@uschille
Copy link
Member

uschille commented Jun 9, 2017

This method seems to only exist as a prototype.

I am wondering if it can be safely removed along with pathManager::SaveConfiguration (this design will always remain a mystery). That method is the only one that makes it necessary to include SimConfig.h.

I would suggest to make the whole PathManager an argument to the constructor of SimConfig, (this would require changin all the calls in the unittests) such that the path to the observable filenames can be initialized correctly during instantiation of SimConfig (what are the New()-new()-Init() shenanigans?).

Perhaps even better to encapsulate the PathManager in SimConfig. So we could scrap the ugly for loop from SimulationMaster.cc and potentially refactor the LbDataSourceIterator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant