You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am wondering if it can be safely removed along with pathManager::SaveConfiguration (this design will always remain a mystery). That method is the only one that makes it necessary to include SimConfig.h.
I would suggest to make the whole PathManager an argument to the constructor of SimConfig,(this would require changin all the calls in the unittests) such that the path to the observable filenames can be initialized correctly during instantiation of SimConfig (what are the New()-new()-Init() shenanigans?).
Perhaps even better to encapsulate the PathManager in SimConfig. So we could scrap the ugly for loop from SimulationMaster.cc and potentially refactor the LbDataSourceIterator.
The text was updated successfully, but these errors were encountered:
This method seems to only exist as a prototype.
I am wondering if it can be safely removed along with pathManager::SaveConfiguration (this design will always remain a mystery). That method is the only one that makes it necessary to include
SimConfig.h
.I would suggest to make the whole(this would require changin all the calls in the unittests) such that the path to the observable filenames can be initialized correctly during instantiation of SimConfig (what are the New()-new()-Init() shenanigans?).PathManager
an argument to the constructor ofSimConfig
,Perhaps even better to encapsulate the
PathManager
inSimConfig
. So we could scrap the uglyfor
loop fromSimulationMaster.cc
and potentially refactor theLbDataSourceIterator
.The text was updated successfully, but these errors were encountered: