Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react v19 #864

Open
benposnick opened this issue Dec 6, 2024 · 6 comments · May be fixed by #863
Open

Support react v19 #864

benposnick opened this issue Dec 6, 2024 · 6 comments · May be fixed by #863
Assignees

Comments

@benposnick
Copy link

Issue

We cannot upgrade to React 19 and Next 15 because of @hello-pangea/dnd dependency on React 18.

What version of React are you using?

Trying to upgrade to [email protected].

What version of @hello-pangea/dnd are you running?

We are using @hello-pangea/[email protected].

npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"19.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.0.0" from @hello-pangea/[email protected]
npm ERR! node_modules/@hello-pangea/dnd
npm ERR!   @hello-pangea/dnd@"^17.0.0" from the root project
@kbehov
Copy link

kbehov commented Dec 8, 2024

I have the same problem, some temporary solution is to use --legacy-peer-deps, but i don't recommend it for production. I hope the lib will be soon updated

@100terres 100terres changed the title Cannot upgrade to React 19 and Next 15 because of @hello-pangea/dnd dependency on React 18 Support react v19 Dec 11, 2024
@100terres 100terres self-assigned this Dec 11, 2024
@100terres 100terres pinned this issue Dec 11, 2024
@100terres
Copy link
Collaborator

Hi @benposnick, I don't have an ETA on this yet, but I'll see what I can do. Hopefully, it won't be too complex to handle. I would like to run our test suite against both react v18 and v19.

@100terres 100terres linked a pull request Dec 11, 2024 that will close this issue
1 task
@benposnick
Copy link
Author

@100terres Thank you so much!!

@100terres
Copy link
Collaborator

I should be able to dedicate time to this issue in the next two weeks. I'm hoping to have something working in early January.

@TexLuciano
Copy link

very good to have feedback for this problem, this is the best lib for dragging

@ahmedyounes
Copy link

please guys 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants