Batch File Converter

[y-bot]

Hi,

I need to convert a lot of gpx files to another format. But for every file I receive the following message when I'm trying to use Batch File Converter: "Could not process "filename.gpx". Bad file?".
GPX File Format plugin is enabled, and I can open every single gpx-file using UI and save it using any other format. But it would require too much time :) I'm using version 1.6.2 for Linux.

Any help would be appreciated. Thank you!

[guiv42]

Hi
I cannot reproduce this issue. My config: Linux openSuse tumbleweed (rolling release), TuxGuitar 1.6.2 installed from distro's repository.

Could you please give more details about your configuration?

• Linux: which distribution and version?
• TuxGuitar 1.6.2: how did you install it? (.tar.gz, .deb, .rpm from this repo, built from source, flatpak from flathub, ...)

[y-bot]

Ubuntu 22.04. Installed from .deb (repo).

[guiv42]

Hmm... even in a Ubuntu 22.04 environment I can't reproduce.

Question 1: any error log when app is launched from command line?

Question 2: here is a detailed description of my test sequence, could you please try to identify any difference with yours?

1. download and install tuxguitar-1.6.2-linux-swt-x86_64.deb file available here
2. create an empty folder ~/tmp/test
3. store 1.gpx and 2.gpx files in this folder
4. create an empty folder ~/tmp/testOut
5. start TuxGuitar, Select menu Tools/Batch File Converter
6. select .tg output file format
7. select ~/tmp/test as input folder
8. select ~/tmp/testOut as output folder
9. click "OK"

Expected and observed result:

• positive feedback in batch converter dialog
• files 1.tg and 2.tg are present in ~/tmp/testOut folder

Also tested with musicxml output format, it works as expected.

[y-bot]

Thank you, but:

1. There are no specific error messages when running Tuxguitar from CLI and using batch file converter. Tried .deb installation and tar.gz archive as well.
2. Did everything exactly as written. No output .tg files and negative feedback in batch file converter window:

Converting: /home/ybot/tmp/testOut/2.tg[Failed]
Could not process "/home/ybot/tmp/test/2.gpx". Bad file?
Converting: /home/ybot/tmp/testOut/1.tg[Failed]
Could not process "/home/ybot/tmp/test/1.gpx". Bad file?

Both files are valid, i.e. can be opened via GUI.

[guiv42]

I've done the test again in a fresh install of Ubuntu 22.04, I still can't reproduce the issue.
I think the only thing I can do right now is to add some verbosity when batch converter fails (done in d3671d2). So that at least we have some error logs. I'll keep you informed.

[y-bot]

Many thanks!

[guiv42]

Thanks @helge17 for the fast delivery!

@y-bot : could you please test with latest pre-release (>=2024-05-16) ?
At least if it still fails we should have visible error logs.

[y-bot]

Here are the logs (for one input file):

org.herac.tuxguitar.io.base.TGFileFormatException: class org.herac.tuxguitar.song.factory.TGFactory$18 cannot be cast to class org.herac.tuxguitar.graphics.control.TGNoteImpl (org.herac.tuxguitar.song.factory.TGFactory$18 and org.herac.tuxguitar.graphics.control.TGNoteImpl are in unnamed module of loader 'app')
	at org.herac.tuxguitar.io.gpx.v6.GPXInputStream.read(GPXInputStream.java:28)
	at org.herac.tuxguitar.io.base.TGSongReaderHelper.read(TGSongReaderHelper.java:28)
	at org.herac.tuxguitar.io.base.TGFileFormatManager.read(TGFileFormatManager.java:49)
	at org.herac.tuxguitar.app.tools.custom.converter.TGConverter.convert(TGConverter.java:57)
	at org.herac.tuxguitar.app.tools.custom.converter.TGConverter.process(TGConverter.java:130)
	at org.herac.tuxguitar.app.tools.custom.converter.TGConverter.process(TGConverter.java:115)
	at org.herac.tuxguitar.app.tools.custom.converter.TGConverterProcess$1.run(TGConverterProcess.java:57)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.ClassCastException: class org.herac.tuxguitar.song.factory.TGFactory$18 cannot be cast to class org.herac.tuxguitar.graphics.control.TGNoteImpl (org.herac.tuxguitar.song.factory.TGFactory$18 and org.herac.tuxguitar.graphics.control.TGNoteImpl are in unnamed module of loader 'app')
	at org.herac.tuxguitar.io.gpx.GPXDocumentParser.getStringFor(GPXDocumentParser.java:624)
	at org.herac.tuxguitar.io.gpx.GPXDocumentParser.parseNote(GPXDocumentParser.java:333)
	at org.herac.tuxguitar.io.gpx.GPXDocumentParser.parseBar(GPXDocumentParser.java:294)
	at org.herac.tuxguitar.io.gpx.GPXDocumentParser.parseMasterBars(GPXDocumentParser.java:225)
	at org.herac.tuxguitar.io.gpx.GPXDocumentParser.parse(GPXDocumentParser.java:62)
	at org.herac.tuxguitar.io.gpx.v6.GPXInputStream.read(GPXInputStream.java:26)
	... 7 more

[guiv42]

Thanks for the test. It's not completely crystal clear, but it seems similar to another issue we already had (see #299).
Investigation in progress...

[y-bot]

Many thanks! If I can provide you with any useful additional information, I would be glad to help to the best of my ability :)

[guiv42]

I have a possible (and partial) explanation. I would appreciate if you can test again, from my experimental branch. See this commit
Just published a pre-release for test only: https://github.com/guiv42/tuxguitar/releases/tag/2024-05-16_batchConverter

[y-bot]

It works! I tried this version on different files and checked the output ones. Everything works perfectly.
Thank you so much for the solution and for maintaining the entire project!

[guiv42]

Thanks for the tests
I will merge this into master, so it becomes available in next release

[guiv42]

What I really don't understand is why I cannot reproduce this issue.
Anyway, it's now merged. By the way the useless cast causing the issue is present in the code since at least 2010 !

[guiv42]

fix is now available (since pre-release 2024-05-19-master)