Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider support for prefers-color-scheme media query (light / dark mode support) #25

Open
KZeni opened this issue Nov 12, 2018 · 0 comments

Comments

@KZeni
Copy link
Contributor

KZeni commented Nov 12, 2018

Ref: https://twitter.com/Keithamus/status/1055179677277384705

Safari Tech Preview now supports a prefers-color-scheme: dark CSS media query that is used when macOS Mojave is in dark mode.

I would love to see this plugin support this separate media query by offering both a "Regular/Normal/Default" (what the plugin currently offers) and "Dark" set of colors to be used (Dark then being optional, of course, and simply offering the same amount of scheme customization as the regular color set.)

Correct me if I'm wrong, but it could be as simple as duplicating the existing admin color controls to have a separate "Dark" set (possibly include a new box or have it as a new column in the existing box... including how it's used by prefers-color-scheme with browsers, of course) and then setting up the dark color customizations to output just like the existing setup with them wrapped in the prefers-color-scheme: dark media query.

@KZeni KZeni changed the title Consider support for prefers-color-scheme media query Consider support for prefers-color-scheme media query (light / dark mode support) Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant