Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify source setting code -consistantly set system states for each source #431

Open
pitts-mo opened this issue Jul 23, 2024 · 0 comments
Open

Comments

@pitts-mo
Copy link
Contributor

I had noticed inconsistency with source behaviors that depend on how the source state was entered. These discrepancies were primarily observed while comparing audio behavior between booting to source vs menu switch to source.

Quickly looking at the code I suspect these places contain code for consolidation:
/src/ui/page_source.c
/src/core/main.c
/src/core/app_state.c

It seems to me that primarily elements from page_source.c should be consolidated under app_state.c (?) so that a single routine would be utilized to consistently set all element states for each of the goggle sources regardless of where/when determination to enter source state was made.

More info:
I had noticed this issue in regard to audio handling over a year ago and I suspect resolving this issue may improve the ability to resolve some of the other consistency failures users have reported. Here are a few prior audio specific issues I suspect to be related:
#115
#328
#372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant