Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps ellipsize test case names with tooltip #102

Closed
Gert-dev opened this issue Nov 30, 2019 · 2 comments
Closed

Perhaps ellipsize test case names with tooltip #102

Gert-dev opened this issue Nov 30, 2019 · 2 comments

Comments

@Gert-dev
Copy link

Gert-dev commented Nov 30, 2019

First off, thanks for this nice extension.

The PHP plugin shows the entire FQCN of the test case class, which makes items in the tree very long. This in turn makes it hard to reach the button to navigate to the source - which I didn't even know existed and I wanted to report an issue about it, until I discovered #69.

An example to demonstrate how long the test names are:

Example

Would it be possible to ellipsize long test names (and e.g. show the full name in a tooltip on hover), or ellipsize the first part of the name (as the last part is usually the most important)? The idea is that there would be no horizontal scrollbar and the action buttons would always be visible on hover to the right. This would be similar to what the Tree Style Tabs extension does in Firefox:

Firefox Tree Style Tabs

Thanks!

@hbenl
Copy link
Owner

hbenl commented Dec 8, 2019

Long test names are already being ellipsized, there is no horizontal scrollbar, the action buttons are visible and the full test name appears on hover:
Screenshot_2019-12-08_12-12-53
All of this is actually standard VS Code behavior for contributed tree views.
The only thing that is missing here is the ability to ellipsize the first part of the name. This could only be done statically (i.e. the first part would always be cut off, even if you increase the width of the side bar) because VS Code doesn't offer any APIs for influencing how it ellipsizes the texts in a tree view. If this is desired, it should be done by the test adapter, it can specify the full name for the tooltip here.

@Gert-dev
Copy link
Author

Gert-dev commented Dec 9, 2019

Thanks for the response. I've created an issue in the adapter repository here: recca0120/vscode-phpunit#47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants