Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sphinx #659

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Upgrade Sphinx #659

merged 5 commits into from
Jan 22, 2024

Conversation

JackPGreen
Copy link
Contributor

Fixes #658

@JackPGreen JackPGreen self-assigned this Jan 15, 2024
@JackPGreen JackPGreen marked this pull request as draft January 15, 2024 17:05
@JackPGreen JackPGreen added Source: Internal dependencies Pull requests that update a dependency file labels Jan 15, 2024
@JackPGreen JackPGreen marked this pull request as ready for review January 15, 2024 17:10
@JackPGreen JackPGreen requested a review from srknzl January 15, 2024 17:10
@@ -84,7 +84,7 @@
#
# This is also used if you do content translation via gettext catalogs.
# Usually you set "language" from the command line for these cases.
language = None
language = "en"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of Sphix does not allow None, but previously None evaluated to en anyway.

sphinx-doc/sphinx#10474

Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built html, it seems fine

@JackPGreen JackPGreen merged commit acc29ba into hazelcast:master Jan 22, 2024
9 checks passed
@JackPGreen JackPGreen deleted the upgrade-sphinx branch August 2, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Source: Internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter_docs_mypy.yaml action fails due to Sphinx version error
2 participants