Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled asyncore.py for Python 3.12+ #649

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Nov 2, 2023

Copied asyncore.py from Python 3.11.6 and removed the deprecation warning which causes that not to run on Python 3.12+. That's only change in that file.

Copy link
Contributor

@ihsandemir ihsandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good until we switch to asyncio.

@yuce yuce merged commit f32c630 into hazelcast:master Nov 3, 2023
9 checks passed
@yuce yuce deleted the asyncore branch November 3, 2023 14:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0.49140% with 405 lines in your changes missing coverage. Please review.

Project coverage is 94.69%. Comparing base (dd6cd1c) to head (610d16e).
Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
hazelcast/asyncore.py 0.00% 403 Missing ⚠️
hazelcast/reactor.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   96.51%   94.69%   -1.82%     
==========================================
  Files         358      359       +1     
  Lines       20962    21368     +406     
==========================================
+ Hits        20231    20235       +4     
- Misses        731     1133     +402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants