Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in exporer activity for Feed, Metrices etc have gone invisible #180

Open
KeenWarrior opened this issue Mar 21, 2017 · 12 comments
Open

Icons in exporer activity for Feed, Metrices etc have gone invisible #180

KeenWarrior opened this issue Mar 21, 2017 · 12 comments
Assignees
@pg301
Labels
GSoC

Comments

@KeenWarrior
Copy link
Contributor

No description provided.

@m-murad
Copy link
Collaborator

m-murad commented Mar 21, 2017

Should I send a proof for this?

@KeenWarrior
Copy link
Contributor Author

@free4murad You mean gif? Sure.

@m-murad
Copy link
Collaborator

m-murad commented Mar 21, 2017

Sorry I meant PR.
Auto correct

@KeenWarrior
Copy link
Contributor Author

@free4murad Two active issues are already under your belt. Let some issues to be enjoyed by others 😉

@anant-dev
Copy link
Contributor

anant-dev commented Mar 21, 2017 •
edited
Loading

@garg-anuj what icon ??
I am getting this screen
screenshot_2017-03-21-22-42-28-073

@KeenWarrior
Copy link
Contributor Author

https://github.com/hawkular/hawkular-android-client/blob/master/mobile/src/main/java/org/hawkular/client/android/explorer/InventoryExplorerActivity.java#L143

@anant-dev
Copy link
Contributor

There is no icons in drawable with the title as in the code (operation_icon, resource_icon , etc) as you can see in https://github.com/hawkular/hawkular-android-client/tree/master/mobile/src/main/res/drawable

@pg301
Copy link
Collaborator

pg301 commented Mar 21, 2017

@garg-anuj I would like to work on this one.

@anant-dev anant-dev mentioned this issue Mar 22, 2017
Closed
@anant-dev
Copy link
Contributor

@garg-anuj @pg301 i have created a pull request for this issue

@KeenWarrior
Copy link
Contributor Author

@pg301 Would you like to complete it?

@pg301
Copy link
Collaborator

pg301 commented Apr 14, 2017

@garg-anuj Sure. I am on it 👍

pg301 added a commit to pg301/hawkular-android-client that referenced this issue Apr 14, 2017
@pg301
Fixed Icons in explorer activity. hawkular#180
e3b8144
pg301 added a commit to pg301/hawkular-android-client that referenced this issue Apr 14, 2017
@pg301
Fixed Icons in explorer activity. hawkular#180
a09a9ec
pg301 added a commit to pg301/hawkular-android-client that referenced this issue Apr 14, 2017
@pg301
Fixed Icons in explorer activity. hawkular#180
f263312 
Fixed Icons in explorer activity. hawkular#180
@pg301 pg301 mentioned this issue Apr 14, 2017
Merged
KeenWarrior pushed a commit that referenced this issue Apr 17, 2017
@pg301 @KeenWarrior
Fix Icons in explorer activity (#207)
81a8111 
Fixed Icons in explorer activity. #180
@m-murad
Copy link
Collaborator

m-murad commented Apr 21, 2017

@garg-anuj @danielpassos @pilhuhn
This is fixed and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pg301 pg301

Labels
GSoC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pg301 @anant-dev @m-murad @KeenWarrior