Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't identify 9 digit zips #12

Open
yankeeinlondon opened this issue Dec 9, 2017 · 3 comments
Open

Doesn't identify 9 digit zips #12

yankeeinlondon opened this issue Dec 9, 2017 · 3 comments

Comments

@yankeeinlondon
Copy link
Contributor

If I type 90291-3064 in as the address (either by itself or at the end of a street address) I'd expect the parser to be able to identify this as a Zip+4 format but instead it either truncates the +4 part of the zip when it is hanging off a street address or associates the +4 part as being a street number.

@hassansin
Copy link
Owner

hassansin commented Dec 15, 2017

In the original Perl implementation the ZIP+4 code is parsed but later stripped out. This library also behaves the same. But I'm open to keep the ZIP+4 code as additional property. Any thoughts on the property name? May be plus4?

@yankeeinlondon
Copy link
Contributor Author

yankeeinlondon commented Dec 15, 2017 via email

@hassansin
Copy link
Owner

Can you try it on zipplus4 branch? https://github.com/hassansin/parse-address/tree/zipplus4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants