Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that GHC+HLS works together #139

Open
hasufell opened this issue Oct 2, 2023 · 4 comments
Open

Check that GHC+HLS works together #139

hasufell opened this issue Oct 2, 2023 · 4 comments

Comments

@hasufell
Copy link
Member

hasufell commented Oct 2, 2023

Check

  • that the recommended GHC works with the recommended HLS
  • that the latest GHC works with the latest HLS
  • that the recommended GHC works with the latest HLS
@hasufell
Copy link
Member Author

the first point seems done:

test_all_hls() {
local bin
local bin_noexe
local bindir
local hls
bindir=$1
for hls in "${bindir}/"haskell-language-server-* ; do
bin=${hls##*/}
bin_noexe=${bin/.exe/}
if ! [[ "${bin_noexe}" =~ "haskell-language-server-wrapper" ]] && ! [[ "${bin_noexe}" =~ "~" ]] && ! [[ "${bin_noexe}" =~ ".shim" ]] ; then
if ghcup_fun install ghc --set "${bin_noexe/haskell-language-server-/}" ; then
"${hls}" typecheck "${test_module}" || fail "failed to typecheck with HLS for GHC ${bin_noexe/haskell-language-server-/}"
else
fail "GHCup failed to install GHC ${bin_noexe/haskell-language-server-/}"
fi
ghcup_fun rm ghc "${bin_noexe/haskell-language-server-/}"
fi
done
ghcup_fun install ghc --set recommended
"$bindir/haskell-language-server-wrapper${ext}" typecheck "${test_module}" || fail "failed to typecheck with HLS wrapper"

The second is to be done.

The third point is questionable.

@fendor
Copy link
Contributor

fendor commented Oct 28, 2024

Quick question

How is the second point supposed to be implemented?
Once GHC 9.12 is released, the latest HLS release will not support the latest GHC version. Or should this be understood as a checklist?

The third point seems sensible to me, isn't that also part of HLS's support policy?

@hasufell
Copy link
Member Author

How is the second point supposed to be implemented?

I guess not really possible without delay.

The third point seems sensible to me, isn't that also part of HLS's support policy?

If that is the case, then sure.

@fendor
Copy link
Contributor

fendor commented Oct 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants