-
Notifications
You must be signed in to change notification settings - Fork 696
Potential Refactors
Francesco Gazzetta edited this page Oct 12, 2018
·
11 revisions
| Name | Short description | Estimated time | Estimated difficulty | Estimated risk |
|---|---|---|---|---|
| UnresolvedPkgLoc | Remove some maybes from PackageLocation, since in some places Nothing never gets used | 2-3h | 2/5 | 2/5 |
In ElaboratedConfiguredPackage.elabPkgSourceLocation, RemoteSourceRepoPackage cannot have a Nothing, but PackageLocation often has Maybe Filepath as local, leading to impossible cases like this one and silly code like this one.
We should remove the maybe wherever is possible.
@fgaz attempted this refactor here (remember to grep for undefined)
Maybe PackageLocation should have two type params: one for RepoTarballPackage (which can be Nothing) and one for the rest. Or just one for RepoTarballPackage.