-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to not remove empty lines #178
Labels
Comments
If it can be done in a way that doesn't regress performance (in a noticeable way) for the current "empty lines are removed" default codepath, this sounds like a welcome improvement! |
Any status on this enhancement? |
No, because of this: |
Well then. I'll see what I can do to contribute! I'm not comfortable being a designated as a maintainer. But I will clone the repository and see how comfortable I become. |
Andreas Abel
I have started looking at the cassava code. I have some changes that resolve several minor warnings in Data.Encoding, Data.Incremental, Data.Util and Data.Conversion.Internal. Test appear to pass. I ran through the examples. Only one example doesn’t work, IncrementalNamedBasedEncode.hs. This is because the go pattern is incomplete, not because of any code changes.
If you like I can push, merge or … those changes. You can review the changes and determine if you would like to incorporate them. Just let me know how you would like to proceed.
Now that I have it running on my system and understand the structure and condition of the code I will see if I can incorporate some the suggested recommendations.
Greg
… On Feb 20, 2023, at 16:30, Andreas Abel ***@***.***> wrote:
No, because of this:
#218 <#218>
—
Reply to this email directly, view it on GitHub <#178 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFB7CS5SK67GLEVWWZREVODWYPV6XANCNFSM4JN53ALQ>.
You are receiving this because you commented.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that it says here that empty lines are removed. This doesn't match how (at least) LibreOffice behaves, and it caused a somewhat surprising bug for me. Would it be reasonable to have an option for the decoder to preserve empty lines?
The text was updated successfully, but these errors were encountered: