From f0a434b8f78fee9f6ee0ad2756a1559ad78a4a4f Mon Sep 17 00:00:00 2001
From: VioletHynes <violet.hynes@hashicorp.com>
Date: Tue, 18 Jun 2024 14:58:43 -0400
Subject: [PATCH] always

---
 .github/workflows/ci.yml                  | 7 ++++---
 .github/workflows/hack-week-benchmark.yml | 3 ++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e42f56306a8a..e52549b7be1a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -47,9 +47,11 @@ jobs:
           no-restore: true # don't download them on a cache hit
 
   bench:
-    if: needs.setup.outputs.app-changed == 'true'
+    if: always()
     name: Bench
-    needs: setup
+    needs:
+      - setup
+      - artifacts
     uses: ./.github/workflows/hack-week-benchmark.yml
     secrets: inherit
     with:
@@ -231,7 +233,6 @@ jobs:
       - test-go-race
       - test-go-fips
       - test-ui
-      - bench
     if: always()
     runs-on: ${{ github.repository == 'hashicorp/vault' && 'ubuntu-latest' || fromJSON('["self-hosted","linux","small"]') }}
     permissions: write-all # Ensure we have id-token:write access for vault-auth.
diff --git a/.github/workflows/hack-week-benchmark.yml b/.github/workflows/hack-week-benchmark.yml
index 0b643331acd4..380b59ac9871 100644
--- a/.github/workflows/hack-week-benchmark.yml
+++ b/.github/workflows/hack-week-benchmark.yml
@@ -10,7 +10,7 @@ on:
         default: ""
 
 jobs:
-  test:
+  bench:
     name: Bench
     runs-on: ubuntu-latest
     steps:
@@ -26,6 +26,7 @@ jobs:
           ref: ${{ inputs.checkout-ref }}
 
       - name: Install cob
+        # I know this isn't great, but it's hack week
         run: curl -sfL https://raw.githubusercontent.com/knqyf263/cob/master/install.sh | sudo sh -s -- -b /usr/local/bin
 
       - name: Run Benchmark