-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate bigquery reservation name match expected format #9609
Milestone
Comments
github-actions
bot
added
service/bigquery
forward/review
In review; remove label to forward
labels
Aug 17, 2023
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this issue
Feb 8, 2024
…y_platform_config (hashicorp#9609) * Reapply "Add client config and permissions to google_identity_platform_config (hashicorp#9417)" This reverts commit 1c1f4d2844b9708f272601555212700382a78e44. * Fix diff from API for GCIP client * Add mfa config to GCIP * Add multiTenant to google_identity_platform_config * Add monitoring and request Logging to google_identity_platform_config * Add test cases * Extend update test to the new attributes * Findings from review * First set of review findings from zli82016 * Fix monitoring permadiff via custom flatten * Fix client.permissions permadiff via custom flatten * Fix mfa.state permadiff * Adapt tests to latest changes * Ignore only outputs for the import verify [upstream:6029bee2dcd6180a177d33d3b96d4ae3967cc957] Signed-off-by: Modular Magician <[email protected]>
modular-magician
added a commit
that referenced
this issue
Feb 8, 2024
…y_platform_config (#9609) (#17225) * Reapply "Add client config and permissions to google_identity_platform_config (#9417)" This reverts commit 1c1f4d2844b9708f272601555212700382a78e44. * Fix diff from API for GCIP client * Add mfa config to GCIP * Add multiTenant to google_identity_platform_config * Add monitoring and request Logging to google_identity_platform_config * Add test cases * Extend update test to the new attributes * Findings from review * First set of review findings from zli82016 * Fix monitoring permadiff via custom flatten * Fix client.permissions permadiff via custom flatten * Fix mfa.state permadiff * Adapt tests to latest changes * Ignore only outputs for the import verify [upstream:6029bee2dcd6180a177d33d3b96d4ae3967cc957] Signed-off-by: Modular Magician <[email protected]>
Confirmed issue! This is a proposal to include underscores on the name argument of the |
I think this is actual requesting to validate the existing allowed format, so that underscores (and other disallowed characters) produce a better error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Community Note
Affected Resource(s)
Description
Bigquery reservations can only use alphanumeric characters and dashes. If you try to include something else (like an underscore) you will get the following unhelpful error from the API:
References
b/359704912
The text was updated successfully, but these errors were encountered: