Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Support for making key vault cache population togglable #26504

Open
1 task done
alex-goncharov opened this issue Jun 28, 2024 · 1 comment
Open
1 task done

Make Support for making key vault cache population togglable #26504

alex-goncharov opened this issue Jun 28, 2024 · 1 comment

Comments

@alex-goncharov
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Commit f61338f introduced cache for key vaults, which gets a list of all key vaults in the subscription and then reads each for up to date details.

This poses a problem for subscriptions with a substantial amount of key vaults and a noticeable rate of changes, where one or two plans can lock down a subscription by hitting API rate limits.

Is it possible to make the cache feature togglable via provider configuration?

New or Affected Resource(s)/Data Source(s)

azurerm_key_vault

Potential Terraform Configuration

provider "azurerm" {
  features {
    key_vault {
     enable_cache = true|false
    }
  }
}

References

No response

@alex-goncharov
Copy link
Contributor Author

With one of the subscriptions that look like this

$ az resource list --resource-type Microsoft.KeyVault/vaults --subscription XXX | jq '. | length'
894

An "application shell" in this subscription has a single KV in its resource group, and a couple of PRs lock the whole set-up down on version 3.106. 3.105 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants