Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_cloudwatch_event_target #38267

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

aws_cloudwatch_event_target #38267

wants to merge 2 commits into from
+93 −2

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jul 5, 2024 •
edited
Loading

Description

Relations

Closes #38265

References

Default value is 24 hours
https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-create-rule-schedule.html#eb-create-scheduled-rule-target

Output from Acceptance Testing

% make testacc TESTS=TestAccEventsTarget_RetryPolicy_update PKG=events
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsTarget_RetryPolicy_update'  -timeout 360m
=== RUN   TestAccEventsTarget_RetryPolicy_update
=== PAUSE TestAccEventsTarget_RetryPolicy_update
=== CONT  TestAccEventsTarget_RetryPolicy_update
--- PASS: TestAccEventsTarget_RetryPolicy_update (34.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	50.765s

...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner July 5, 2024 20:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/events Issues and PRs that pertain to the events service. labels Jul 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 5, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 5, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/events Issues and PRs that pertain to the events service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: cloudwatch_event_target.retryPolicy.maximumEventAgeInSeconds is not optional
2 participants
@nikhil-goenka @justinretzolk