Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDowns don't have type to search on Linux #71

Open
jonko0493 opened this issue Apr 2, 2023 · 8 comments
Open

DropDowns don't have type to search on Linux #71

jonko0493 opened this issue Apr 2, 2023 · 8 comments
Labels
bug Something isn't working eto change needed Issues that are blocked on changes required in the underlying Eto.Forms framework linux Used on issues that affect Linux specifically

Comments

@jonko0493
Copy link
Member

GTK must implement them differently than MonoMac and WPF. We should have this implemented as long drop downs are borderline unusable on Linux rn. Possibly will require implementing a custom GTK control for this.

@jonko0493 jonko0493 added bug Something isn't working linux Used on issues that affect Linux specifically labels Apr 2, 2023
@jonko0493
Copy link
Member Author

Ah, got it -- looks like there's a property in GTK dropdowns for "enable-search" that's for some reason set to false by default. We'll need to figure out how to get that set to true for our dropdowns. https://docs.gtk.org/gtk4/property.DropDown.enable-search.html

@jonko0493
Copy link
Member Author

Here's a fun fact I just learned -- the link above is for GTK4, but Eto uses Gtk# which is still on GTK3. GTK3 uses combo boxes that don't have that "enable-search" property. D:

@jonko0493
Copy link
Member Author

jonko0493 commented Apr 2, 2023

Note -- we have made our lives hard by making the namespace SerialLoops.Gtk -- it makes it difficult to reference the actual Gtk namespace as it automatically resolves to SerialLoops.Gtk. We might consider renaming it to something like SerialLoops.Linux.

jk, using GtkReal = Gtk; does the trick.

@jonko0493
Copy link
Member Author

@jonko0493
Copy link
Member Author

I tried making the combobox have an "entry" per this documentation: https://docs.gtk.org/gtk3/property.ComboBox.has-entry.html

That definitely added an entry, but it doesn't work the way we want.

@jonko0493
Copy link
Member Author

Conclusion from offline -- while there are hacks we could do here to make this better (and maybe we will do one later down the line), the true solution for this is to have a GTK4 binding with Eto.

@jonko0493 jonko0493 changed the title DropDowns don't have type to search on Linux (???) DropDowns don't have type to search on Linux Apr 2, 2023
@jonko0493 jonko0493 moved this to Blocked in Serial Loops Apr 3, 2023
@jonko0493 jonko0493 added the eto change needed Issues that are blocked on changes required in the underlying Eto.Forms framework label Jan 24, 2024
@jonko0493
Copy link
Member Author

Doesn't work on any devices now in Avalonia. 😎

Just means we'll probably have to implement it ourselves. But when we do, it should work everywhere.

@jonko0493
Copy link
Member Author

Blocked on this merging: AvaloniaUI/Avalonia#17506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eto change needed Issues that are blocked on changes required in the underlying Eto.Forms framework linux Used on issues that affect Linux specifically
Projects
Status: In PR
Development

No branches or pull requests

2 participants