-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ASC Reader start time #1788
base: main
Are you sure you want to change the base?
Conversation
- update upload/download workflow actions - use OIDC credentials to release to PyPI
to get correct `absolute` timestamp
An
In release-4.4.0 branch
here,
Besides, 2 more changes to unify ASCReader with other Reader(BLFReader):
To reproduce the issue, use the code below to read the
|
At present, tests below failed:
This is because it is asserted between For example, snipped codes in
here To solve this, we can delete start_timestamp when reading messages in
just do From my side, this change is correct. Users can get absolute timestamp in their own scripts. |
to get correct
absolute
timestamp