Ixxat bus refactor to use VCI4 driver only #1611
Open
+8,932
−2,321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test coverage with an Ixxat USB-to-CAN V2 Compact plugged in to a silent bus:
|
|
@zariiii9003 I think this is ready for scrutiny. |
I will check this on the weekend since this is rather big. Thank you for your great effort! |
|
@MattWoodhead Just in case you missed it: MattWoodhead#1 |
Log a warning when a VCI_E_ACCESSDENIED error is returned from a driver function call.
|
@MattWoodhead Any chance to get this ready for a 4.3 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement ixxat bus in a single class using only the VCI4 driver as discussed here