Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Support for MDF4 CAN bus logging files [PR ready] #1883

Open
MatinF opened this issue Oct 30, 2024 · 1 comment
Open

FEATURE REQUEST: Support for MDF4 CAN bus logging files [PR ready] #1883

MatinF opened this issue Oct 30, 2024 · 1 comment

Comments

@MatinF
Copy link

MatinF commented Oct 30, 2024

Is your feature request related to a problem? Please describe.

The current MDF4 reader in the python-can project is only able to load MDF4 files generated by the MDF4 writer in the project, or MDF4 files having the exact same internal structure. This severely limits the number of MDF4 files with CAN data which can be loaded into the python-can ecosystem for analysis and playback.

Describe the solution you'd like

An expansion of the MDF4 reader capabilities to support MDF4 CAN bus logging files in general. I.e. instead of always expecting CAN DataFrames to be group 0, allow these to be any group, and even span multiple groups. The asammdf package the reader/writer leverages for the heavy lifting behind the scenes already supports loading of more complex files/other structures.

We can provide a PR for expanding the MDF4 readers capabilities to support more generalized CAN bus logging files (in fact we have already prepared and tested one).

Please let us know whether this is something you are open to, then we will formally prepare the PR.

@MatinF
Copy link
Author

MatinF commented Nov 1, 2024

As an update, we have now made a PR for this:
#1884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant