Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fail_recovery tests default #52

Open
AbyelT opened this issue Sep 1, 2022 · 0 comments
Open

Make fail_recovery tests default #52

AbyelT opened this issue Sep 1, 2022 · 0 comments

Comments

@AbyelT
Copy link
Contributor

AbyelT commented Sep 1, 2022

The tests in recovery_test.rs are currently ignored, the reason is that they do not correctly answer the futures of the last proposals.

The futures are stored as a LinkedList and handled in the answer_future() function, currently it reads decided entries and replies to futures in a random order. It would be better to check and reply to the future each decided entry matches to.

By using Ask<Value, ()>, one could include the proposals in the Futures and check the futures that should be replied to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant