Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flushing entries on Prepare #126

Open
kevin-harrison opened this issue Nov 13, 2023 · 0 comments
Open

Flushing entries on Prepare #126

kevin-harrison opened this issue Nov 13, 2023 · 0 comments
Labels
enhancement Improvements that enhances performance good first issue Good for newcomers

Comments

@kevin-harrison
Copy link
Contributor

Right now we flush entries on receiving a Prepare message. There is nothing wrong with this, but it could be optimized. If we in general only send Accepted after flushing then actually this is not strictly necessary. (any chosen entry must be flushed among a majority and if we haven't flushed it, then we will get it in the AcceptSync). To prevent flushing stuff that will anyway get overwritten, we should perhaps do some checks here first. The most basic check is if the leader is more updated than us, we don't flush. There are probably more sophisticated checks we can do.

@haraldng haraldng added enhancement Improvements that enhances performance good first issue Good for newcomers labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements that enhances performance good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants