Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework error handling #124

Open
kevin-harrison opened this issue Nov 13, 2023 · 0 comments
Open

Rework error handling #124

kevin-harrison opened this issue Nov 13, 2023 · 0 comments
Labels
enhancement Improvements that enhances performance needs further discussion Further brainstorming needed usability Improvements to make the library easier to use

Comments

@kevin-harrison
Copy link
Contributor

kevin-harrison commented Nov 13, 2023 •
edited
Loading

Right now Omnipaxo's functions panic on errors instead of returning results. This makes it awkward for users to recover their crashed Omnipaxos instances. It's standard for library crates to generate thiserror errors and allow users to handle them. Furthermore, Omnipaxos can be made to recover from errors in the back-end storage without restarting the entire instance. We need to be careful to only update in-memory state if a call to the back-end storage was successful.
@haraldng haraldng added enhancement Improvements that enhances performance needs further discussion Further brainstorming needed usability Improvements to make the library easier to use labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements that enhances performance needs further discussion Further brainstorming needed usability Improvements to make the library easier to use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haraldng @kevin-harrison