tests for fix ref integrity with client assigned ids #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6523 +/- ##
============================================
- Coverage 83.54% 83.17% -0.37%
- Complexity 27432 28180 +748
============================================
Files 1707 1778 +71
Lines 106185 110123 +3938
Branches 13397 13848 +451
============================================
+ Hits 88710 91596 +2886
- Misses 11750 12560 +810
- Partials 5725 5967 +242 ☔ View full report in Codecov by Sentry. |
TipzCM
approved these changes
Dec 3, 2024
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/index/IdHelperServiceTest.java
Outdated
Show resolved
Hide resolved
...-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4ReferentialIntegrityTest.java
Outdated
Show resolved
Hide resolved
added 7 commits
December 9, 2024 16:27
…ends on client id strategy
…-integrity-with-client-assigned-ids-2
…-integrity-with-client-assigned-ids-2
jmarchionatto
deleted the
jd-20241113-fix-ref-integrity-with-client-assigned-ids-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only contains unit tests for #6476. My original PR contained these tests + a fix, however, IdHelperService was recently refactored as part of #6460. This refactor fixed the bug, but I thought it would still be good to include these unit tests.
Closes #6476