mdm delete with cascade bug fix #6540
Open
+224
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
dotasek
approved these changes
Dec 6, 2024
hapi-fhir-server-mdm/src/main/java/ca/uhn/fhir/mdm/interceptor/MdmStorageInterceptor.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6540 +/- ##
============================================
- Coverage 83.54% 83.18% -0.37%
- Complexity 27432 28168 +736
============================================
Files 1707 1778 +71
Lines 106185 110128 +3943
Branches 13397 13844 +447
============================================
+ Hits 88710 91606 +2896
- Misses 11750 12554 +804
- Partials 5725 5968 +243 ☔ View full report in Codecov by Sentry. |
tadgh
approved these changes
Dec 11, 2024
...uhn/hapi/fhir/changelog/7_8_0/6539-handle-mdm-link-deletion-when-delete-cascade-enabled.yaml
Outdated
Show resolved
Hide resolved
...uhn/hapi/fhir/changelog/7_8_0/6539-handle-mdm-link-deletion-when-delete-cascade-enabled.yaml
Show resolved
Hide resolved
hapi-fhir-server-mdm/src/main/java/ca/uhn/fhir/mdm/interceptor/MdmStorageInterceptor.java
Outdated
Show resolved
Hide resolved
hapi-fhir-server-mdm/src/main/java/ca/uhn/fhir/mdm/interceptor/MdmStorageInterceptor.java
Show resolved
Hide resolved
hapi-fhir-server-mdm/src/main/java/ca/uhn/fhir/mdm/interceptor/MdmStorageInterceptor.java
Outdated
Show resolved
Hide resolved
hapi-fhir-server-mdm/src/main/java/ca/uhn/fhir/mdm/interceptor/MdmStorageInterceptor.java
Outdated
Show resolved
Hide resolved
added 3 commits
December 11, 2024 15:55
tadgh
reviewed
Dec 11, 2024
...uhn/hapi/fhir/changelog/7_8_0/6539-handle-mdm-link-deletion-when-delete-cascade-enabled.yaml
Show resolved
Hide resolved
tadgh
approved these changes
Dec 11, 2024
...hir-jpaserver-mdm/src/test/java/ca/uhn/fhir/jpa/mdm/interceptor/MdmStorageInterceptorIT.java
Outdated
Show resolved
Hide resolved
| assertTrue(outcome.getOperationOutcome() instanceof OperationOutcome); | ||
| OperationOutcome out = (OperationOutcome) outcome.getOperationOutcome(); | ||
| assertTrue(out.getIssue().stream() | ||
| .anyMatch(f -> f.getDiagnostics().toLowerCase().contains("successfully deleted 2 resource(s)"))); |
There was a problem hiding this comment.
question: I know this is likely not new, but .... like 5 resources were deleted here, weird that it would say 2.
There was a problem hiding this comment.
I think this is the result of using a 'fake' cascading interceptor.
The real one actually goes through and adds additional messages. But that code isn't in the test, so it only says it deletes 2 resources (no matter what)
added 2 commits
December 11, 2024 16:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6539