Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding message broker ChannelSettings in MDM #6497

Conversation

volodymyr-korzh
Copy link
Collaborator

@volodymyr-korzh volodymyr-korzh commented Nov 22, 2024

No description provided.

@volodymyr-korzh volodymyr-korzh self-assigned this Nov 22, 2024
@volodymyr-korzh volodymyr-korzh linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (406db33) to head (713d861).
Report is 133 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6497      +/-   ##
============================================
- Coverage     83.54%   83.19%   -0.35%     
- Complexity    27432    28071     +639     
============================================
  Files          1707     1771      +64     
  Lines        106185   109498    +3313     
  Branches      13397    13792     +395     
============================================
+ Hits          88710    91102    +2392     
- Misses        11750    12463     +713     
- Partials       5725     5933     +208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@volodymyr-korzh volodymyr-korzh marked this pull request as ready for review November 29, 2024 16:35
@volodymyr-korzh volodymyr-korzh changed the title Add support for disabling prefixChannelName to message broker ChannelSettings Allow overriding message broker ChannelSettings in MDM Dec 10, 2024
@tadgh tadgh merged commit fe3baa2 into master Dec 12, 2024
65 of 67 checks passed
@tadgh tadgh deleted the 6496-add-support-for-prefixchannelname-to-message-broker-channelsettings branch December 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding message broker ChannelSettings in MDM
3 participants