Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "update" operations; use them to clean up Shell validation tests #1719

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Add "update" operations; use them to clean up Shell validation tests #1719

merged 9 commits into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. Update variable names 

    The old names didn't make a lot of sense. Since we don't know anything
about the points that the caller passes in, it only makes sense to name
the faces after the order of the points, nothing that implies a position
or orientation.
    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    d9a5f22 View commit details
    Browse the repository at this point in the history

  2. Make return value more explicit

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    21f3fc5 View commit details
    Browse the repository at this point in the history

  3. Add UpdateShell

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    eebd7b7 View commit details
    Browse the repository at this point in the history

  4. Add UpdateFace

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6e6c1d5 View commit details
    Browse the repository at this point in the history

  5. Add UpdateCycle

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    297db23 View commit details
    Browse the repository at this point in the history

  6. Add UpdateHalfEdge

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    989fb3f View commit details
    Browse the repository at this point in the history

  7. Make validation test case more specific

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    007e605 View commit details
    Browse the repository at this point in the history

  8. Add UpdateShell::remove_face

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    d8f3871 View commit details
    Browse the repository at this point in the history

  9. Make validation test case more specific

    @hannobraun
    hannobraun committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    b339ab7 View commit details
    Browse the repository at this point in the history