Bypass GlobalCurve in sweep algorithm
#1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on changes to `GlobalCurve`. Once those changes come to fruition, it will no longer be able to support that `Sweep` implementation.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #1079 is implemented, it will no longer be possible for
GlobalCurveto support the previous sweep implementation (see that issue for context). This pull request takes completely bypassesGlobalCurvein the sweep code, paving the way for #1079.This exposes a limitation in the sweep algorithm, namely that it's not possible to sweep from a sketch that is defined in a curved surface. Please note that...
GlobalCurverepresentation.I'm going to open a new issue after merging this, to track this limitation.