Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging of this lib has multiple issues #207

Open
KOLANICH opened this issue Jul 23, 2021 · 0 comments · May be fixed by #230
Open

Packaging of this lib has multiple issues #207

KOLANICH opened this issue Jul 23, 2021 · 0 comments · May be fixed by #230

Comments

@KOLANICH
Copy link
Contributor

KOLANICH commented Jul 23, 2021 •
edited
Loading

  1. It puts too lot of unneeded stuff into include dir. I.e. the headers directly in /usr/include/ are either unneeded (just there to include the header within a specialized dir) or can be moved into the specialized dir.
  2. unicode-db and ctll should be separate packages (in all senses). It is possible to cause importing ctre to cause importing of unicode-db and ctll.
  3. the package name is incorrect for debian/ubuntu/fedora. It should be not just ctre, but libctre-dev for Debian and libctre-devel for Fedora.
  4. There is no file for pkg-config packaged. I can send a PR implementing it, but the issue with unicode-db should be resolved first.
  5. dpkg-buildpackage is not needed in order to build deb packages. CPack builds them themself.
friendlyanon added a commit to friendlyanon/compile-time-regular-expressions that referenced this issue Nov 8, 2021
@friendlyanon
Improve the quality of the CMake build scripts
a8920de 
This commit does a couple changes:

* Actually adheres to the declared CMake 3.8 requirement
  * HOMEPAGE_URL in project() was added in 3.12
  * install(TARGETS) requires the DESTINATION argument
  * Tests' CML uses CONFIGURE_DEPENDS from CMake 3.12
* Removes unnecessary things
  * Looking for RPM and DEB packagers is pointless
  * Misc arguments to CMake commands
* Improves correctness
  * Includes CPack and CTest modules only if top level
  * Assigns install rules to a project specific component to not clobber
    the global, `Unspecified` one
  * Adds a warning guard for projects that vendor ctre
  * CMAKE_INSTALL_PREFIX may change at install time, so .pc file is
    generated at that time to ensure the prefix is always right
  * Enables the install rules to be opt-out using the CMake built-in
    variable
  * Emulates ARCH_INDEPENDENT for the version config
  * Installs headers to their own directory (fixes hanickadot#207)
* Small optimization
  * LANGUAGES can be set to NONE, because this is a header only library
@friendlyanon friendlyanon linked a pull request Nov 8, 2021 that will close this issue
Open
friendlyanon added a commit to friendlyanon/compile-time-regular-expressions that referenced this issue Nov 14, 2021
@friendlyanon
Improve the quality of the CMake build scripts
9589f7c 
This commit does a couple changes:

* Actually adheres to the declared CMake 3.8 requirement
  * HOMEPAGE_URL in project() was added in 3.12
  * install(TARGETS) requires the DESTINATION argument
  * Tests' CML uses CONFIGURE_DEPENDS from CMake 3.12
* Removes unnecessary things
  * Looking for RPM and DEB packagers is pointless
  * Misc arguments to CMake commands
* Improves correctness
  * Includes CPack and CTest modules only if top level
  * Assigns install rules to a project specific component to not clobber
    the global, `Unspecified` one
  * Adds a warning guard for projects that vendor ctre
  * CMAKE_INSTALL_PREFIX may change at install time, so .pc file is
    generated at that time to ensure the prefix is always right
  * Enables the install rules to be opt-out using the CMake built-in
    variable
  * Emulates ARCH_INDEPENDENT for the version config
  * Installs headers to their own directory (fixes hanickadot#207)
  * Use CTest for testing
* Small optimization
  * LANGUAGES can be set to NONE, because this is a header only library
friendlyanon added a commit to friendlyanon/compile-time-regular-expressions that referenced this issue Nov 24, 2021
@friendlyanon
Improve the quality of the CMake build scripts
211ff9e 
This commit does a couple changes:

* Actually adheres to the declared CMake 3.8 requirement
  * HOMEPAGE_URL in project() was added in 3.12
  * install(TARGETS) requires the DESTINATION argument
  * Tests' CML uses CONFIGURE_DEPENDS from CMake 3.12
* Removes unnecessary things
  * Looking for RPM and DEB packagers is pointless
  * Misc arguments to CMake commands
* Improves correctness
  * Includes CPack and CTest modules only if top level
  * Assigns install rules to a project specific component to not clobber
    the global, `Unspecified` one
  * Adds a warning guard for projects that vendor ctre
  * CMAKE_INSTALL_PREFIX should be set at configure time if the person
    building wants .pc files, so attempt to detect that error
  * Enables the install rules to be opt-out using the CMake built-in
    variable
  * Emulates ARCH_INDEPENDENT for the version config
  * Installs headers to their own directory (fixes hanickadot#207)
  * Use CTest for testing
* Small optimization
  * LANGUAGES can be set to NONE, because this is a header only library
friendlyanon added a commit to friendlyanon/compile-time-regular-expressions that referenced this issue Dec 4, 2021
@friendlyanon
Improve the quality of the CMake build scripts
e7e1236 
This commit does a couple changes:

* Actually adheres to the declared CMake 3.8 requirement
  * HOMEPAGE_URL in project() was added in 3.12
  * install(TARGETS) requires the DESTINATION argument
  * Tests' CML uses CONFIGURE_DEPENDS from CMake 3.12
* Removes unnecessary things
  * Looking for RPM and DEB packagers is pointless
  * Misc arguments to CMake commands
* Improves correctness
  * Includes CPack and CTest modules only if top level
  * Assigns install rules to a project specific component to not clobber
    the global, `Unspecified` one
  * Adds a warning guard for projects that vendor ctre
  * CMAKE_INSTALL_PREFIX should be set at configure time if the person
    building wants .pc files, so attempt to detect that error
  * Enables the install rules to be opt-out using the CMake built-in
    variable
  * Emulates ARCH_INDEPENDENT for the version config
  * Installs headers to their own directory (fixes hanickadot#207)
  * Use CTest for testing
* Small optimization
  * LANGUAGES can be set to NONE, because this is a header only library
@boris-kolpackov boris-kolpackov mentioned this issue Feb 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the quality of the CMake build scripts friendlyanon/compile-time-regular-expressions
1 participant
@KOLANICH