Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to set BetterErrors::Middleware.allow_ip! #4

Open
iJackUA opened this issue Apr 18, 2018 · 1 comment
Open

Provide a way to set BetterErrors::Middleware.allow_ip! #4

iJackUA opened this issue Apr 18, 2018 · 1 comment
Assignees

Comments

@iJackUA
Copy link

iJackUA commented Apr 18, 2018

Whey you run Hanami app inside Docker/Vagrant container (in dev env)
you request end up "as being from external REMOTE_ADDR" and BetterErrors does not show itself for security reasons.
We need a way to setup this option, for example:

BetterErrors::Middleware.allow_ip! '172.18.0.0/16'

Maybe it should be an ENV var available?
Like HANAMI_WEBCONSOLE_TRUSTED_IP ?

Details: https://github.com/charliesome/better_errors/wiki/Allowing-access-to-the-console

@jodosha
Copy link
Member

jodosha commented May 7, 2018

@iJackUA Thanks for reporting this. I'd love to hear your opinion here: hanami/hanami#930

It's a ticket to solve the root problem (plugins that can accept settings). It would solve the allowed IPs problem as well.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants