Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bright black in labels #141

Open
haliphax opened this issue Mar 27, 2024 · 3 comments
Open

bright black in labels #141

haliphax opened this issue Mar 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@haliphax
Copy link
Owner

haliphax commented Mar 27, 2024

The BannerApp's Label component has an issue with the intensity SGR code; bright black is not given higher intensity and appears the same as dark black.

This will need some more experimentation to suss out. I don't think it's an issue with the container, but with the host operating system, as this does not happen when running the container on my local machine.

@haliphax haliphax added the bug Something isn't working label Mar 27, 2024
@haliphax
Copy link
Owner Author

Using Ubuntu as the host (vs. alpine) made no difference. 🤔

@haliphax
Copy link
Owner Author

haliphax commented Mar 27, 2024

Replacing the use of intensity for foreground color (e.g. \x1b[1;30m) with the use of aixterm "bright color" variants (e.g. \x1b[90m) renders correctly. No idea what's going on, but I feel like this issue is going to be deep.

https://en.wikipedia.org/wiki/ANSI_escape_code#Colors

@haliphax
Copy link
Owner Author

This appears to be a bug in either rich or textual, and not due to my system. I had a previous version installed in my local environment which was leading to the difference in rendering behavior. Now that I have the latest dependencies installed locally, I am able to reproduce the issue reliably.

@haliphax haliphax changed the title termcaps issue? bright black in labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant